Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serious incen mini rework, reduces explosion strenght and price #6035

Closed
wants to merge 4 commits into from

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Mar 28, 2024

About the pull request

reduces explosion about 1/3, justifing the incendiary payload in casing of the same size, reduces price as it might be a bit stronger then normal minirocket but not streight up stronger with no other drawback.
old explosion values based on range are
200, 156, 112, 68, 24
new one
130, 100, 70, 40, 10

the numbers are up for debate, but the concept is hopefully acceptable

(Others have said they would reduce the incen mini explosion when I have been asking long ago but welp...)

Explain why it's good for the game

puts incen minirockets into its own position, weaker explosion the minirocket and weaker fire then laser but has both. Having super strong option behind what is basicly paywall is weard and this should allow for them to be more viable while getting it line with other ordinance.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: reduces incen minirocket strength from 200 to 130
balance: reduces incen minirocket falloff from 44 to 30
balance: reduces incen minirocket price from 500 to 350
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Mar 28, 2024
@cuberound cuberound changed the title serious incen mini rework, reduces explosion strenght and price serious incen mini rework, reduces explosion strenghth and price Mar 28, 2024
@cuberound cuberound changed the title serious incen mini rework, reduces explosion strenghth and price serious incen mini rework, reduces explosion strenght and price Mar 28, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 5, 2024
Comment on lines +415 to +417
point_cost = 350
explosion_strength = 130
explosion_falloff = 30
Copy link
Contributor

@Drulikar Drulikar Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs to change this much.

Maybe 400 pts, revert falloff change, and 150 strength?

But as I said in your other PR in general fire missions probably overall need to be more powerful. Only if you feel this is exceptionally better than the others is any change necessary.

@Drulikar Drulikar marked this pull request as draft April 6, 2024 05:59
@github-actions github-actions bot closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants