Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serious incen mini rework, reduces explosion strenght and price #6035

Closed
wants to merge 4 commits into from
Closed

serious incen mini rework, reduces explosion strenght and price #6035

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd1a28f
serious incen mini rework
uuuuhuuuu Mar 28, 2024
5e9eb30
escaped renaming
uuuuhuuuu Mar 28, 2024
b70064b
bad name
uuuuhuuuu Mar 28, 2024
23f839c
missing var
uuuuhuuuu Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions code/modules/cm_marines/dropship_ammo.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,18 +382,20 @@
transferable_ammo = TRUE
point_cost = 300
fire_mission_delay = 3 //high cooldown
var/explosion_strength = 200
var/explosion_falloff = 44

/obj/structure/ship_ammo/minirocket/detonate_on(turf/impact, obj/structure/dropship_equipment/weapon/fired_from)
impact.ceiling_debris_check(2)
spawn(5)
cell_explosion(impact, 200, 44, EXPLOSION_FALLOFF_SHAPE_LINEAR, null, create_cause_data(initial(name), source_mob))
var/datum/effect_system/expl_particles/P = new/datum/effect_system/expl_particles()
P.set_up(4, 0, impact)
P.start()
cell_explosion(impact, explosion_strength, explosion_falloff, EXPLOSION_FALLOFF_SHAPE_LINEAR, null, create_cause_data(initial(name), source_mob))
var/datum/effect_system/expl_particles/expl_particles = new/datum/effect_system/expl_particles()
expl_particles.set_up(4, 0, impact)
expl_particles.start()
spawn(5)
var/datum/effect_system/smoke_spread/S = new/datum/effect_system/smoke_spread()
S.set_up(1,0,impact,null)
S.start()
var/datum/effect_system/smoke_spread/smoke = new/datum/effect_system/smoke_spread()
smoke.set_up(1,0,impact,null)
smoke.start()
if(!ammo_count && loc)
qdel(src) //deleted after last minirocket is fired and impact the ground.

Expand All @@ -410,8 +412,9 @@
name = "\improper AGR-59-I 'Mini-Mike'"
desc = "The AGR-59-I 'Mini-Mike' incendiary minirocket is a cheap and efficient means of putting hate down range AND setting them on fire! Though rockets lack a guidance package, it makes up for it in ammunition count. Can be loaded into the LAU-229 Rocket Pod."
icon_state = "minirocket_inc"
point_cost = 500
fire_mission_delay = 3 //high cooldown
point_cost = 350
explosion_strength = 130
explosion_falloff = 30
Comment on lines +415 to +417
Copy link
Contributor

@Drulikar Drulikar Apr 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs to change this much.

Maybe 400 pts, revert falloff change, and 150 strength?

But as I said in your other PR in general fire missions probably overall need to be more powerful. Only if you feel this is exceptionally better than the others is any change necessary.


/obj/structure/ship_ammo/minirocket/incendiary/detonate_on(turf/impact, obj/structure/dropship_equipment/weapon/fired_from)
..()
Expand Down
Loading