Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilized metallic foam, a gimmick new flamer fuel #6062

Merged
merged 26 commits into from
Apr 19, 2024
Merged

Stabilized metallic foam, a gimmick new flamer fuel #6062

merged 26 commits into from
Apr 19, 2024

Conversation

iloveloopers
Copy link
Contributor

@iloveloopers iloveloopers commented Apr 1, 2024 •
edited
Loading

About the pull request

billions must foam
adds in stabilized metallic foam, usable by flamers to make iron foam
uses 2 units per tile that the main line travels
max range of 6 tiles

Explain why it's good for the game

billions must foam
new and exciting way to block xenos from retreating
can also be used by engineers to patch breaches
more custom flamer fuel variety

Testing Photographs and Procedure

https://www.youtube.com/watch?v=2x8rWPyxzpA

METALFOAM.CHEMREACTION.mp4

Changelog

🆑
add: adds new flamer fuel type, stabilized metallic foam
add: Incinerator tanks can now hold stabilized metallic foam
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Apr 1, 2024
@iloveloopers
Copy link
Contributor Author

iloveloopers commented Apr 1, 2024 •
edited
Loading

Need to code in nozzle functionality still
edit: chemical cannot be fired from the flamer nozzle attachment due to balance concerns

@iloveloopers iloveloopers marked this pull request as draft April 2, 2024 00:18
@iloveloopers iloveloopers marked this pull request as ready for review April 2, 2024 13:48
@SabreML SabreML added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Apr 3, 2024
@Drulikar Drulikar marked this pull request as draft April 6, 2024 07:26
@iloveloopers iloveloopers marked this pull request as ready for review April 6, 2024 15:45
@Drulikar Drulikar marked this pull request as draft April 7, 2024 01:28
@iloveloopers iloveloopers marked this pull request as ready for review April 7, 2024 14:40
Drulikar
Drulikar requested changes Apr 13, 2024
View reviewed changes
code/modules/reagents/chemistry_reactions/other.dm Outdated Show resolved Hide resolved
code/modules/reagents/chemistry_reactions/other.dm Outdated Show resolved Hide resolved
code/modules/reagents/chemistry_reagents/other.dm Outdated Show resolved Hide resolved
code/modules/reagents/chemistry_reactions/other.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Apr 13, 2024
@iloveloopers iloveloopers marked this pull request as ready for review April 13, 2024 14:36
cm13-github added a commit that referenced this pull request Apr 13, 2024
@cm13-github
TGS Test Merge (#6062)
9fcf7dd
@Steelpoint Steelpoint mentioned this pull request Apr 14, 2024
Closed
3 tasks
Drulikar
Drulikar requested changes Apr 14, 2024
View reviewed changes
code/game/objects/effects/effect_system/foam.dm Outdated Show resolved Hide resolved
code/modules/projectiles/guns/flamer/flamer.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft April 14, 2024 19:51
@iloveloopers
Copy link
Contributor Author

If you say so

@iloveloopers iloveloopers marked this pull request as ready for review April 14, 2024 20:59
cm13-github added a commit that referenced this pull request Apr 15, 2024
@cm13-github
TGS Test Merge (#6062)
14d851b
cm13-github added a commit that referenced this pull request Apr 15, 2024
@cm13-github
TGS Test Merge (#6062)
bcf1b98
@cuberound cuberound mentioned this pull request Apr 16, 2024
Closed
3 tasks
cm13-github added a commit that referenced this pull request Apr 16, 2024
@cm13-github
TGS Test Merge (#6062)
9c7d796
cm13-github added a commit that referenced this pull request Apr 16, 2024
@cm13-github
TGS Test Merge (#6062)
22c1a40
cm13-github added a commit that referenced this pull request Apr 17, 2024
@cm13-github
TGS Test Merge (#6062)
6af521a
cm13-github added a commit that referenced this pull request Apr 17, 2024
@cm13-github
TGS Test Merge (#6062)
7b3b472
@hminh2010 hminh2010 mentioned this pull request Apr 18, 2024
Open
3 tasks
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Apr 19, 2024
@Drulikar Drulikar added this pull request to the merge queue Apr 19, 2024
Merged via the queue into cmss13-devs:master with commit 8525fc3 Apr 19, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Apr 19, 2024
@cm13-github
Automatic changelog for PR #6062 [ci skip]
6267179
@iloveloopers iloveloopers deleted the FOAM-FLAMER branch May 7, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drulikar Drulikar Drulikar approved these changes

Assignees
No one assigned
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Needs Testing Need to test it on the guinea pigs (production server) Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iloveloopers @Drulikar @SabreML