'Search by key' button for the Keybind menu #6070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
force-pushed
the
keybinds-key-search
branch
from
4abddab
to
7f1982b
Compare
harryob
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds a 'search by key' button to the Keybind menu, which scrolls the window to the first entry bound to the inputted key.
Ideally this would somehow loop through everything that the key is bound to, but I haven't been able to figure that out yet.
Explain why it's good for the game
It's easy to search for the name of a keybind if you already know what you're looking for, but if for example you're trying to figure out what the 'F' key is doing, or whether or not a key you want to bind is already in use, then currently you need to look through the whole list manually.
Testing Photographs and Procedure
Screenshots & Videos
xWgBOBDqTk.mp4
Changelog
🆑
ui: Added a 'search by key' button to the Keybind menu.
/:cl: