Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fm timeing changes #6097

Merged
merged 12 commits into from
May 1, 2024
Merged

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Apr 6, 2024

About the pull request

drethek said FMs should be more powerful and told me that the warnings are a bit too mutch, and they are, you can run on the other side of colony from start of warning to when CAS opens fire. this PR shortens the fire

Explain why it's good for the game

still alows you to awoid CAS if you start running when you hear it, while increasing the chance of hitings of those who do not run

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: FM sound is 4 seconds before CAS open fire from 5
balance: FM direction warning is 1 seconds before CAS open fire from 1.5

/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Apr 6, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 14, 2024
@cuberound cuberound marked this pull request as ready for review April 15, 2024 10:27
@cuberound cuberound requested a review from fira as a code owner April 15, 2024 10:27
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Apr 18, 2024
code/game/cas_manager/datums/cas_fire_envelope.dm Outdated Show resolved Hide resolved
code/game/cas_manager/datums/cas_fire_envelope.dm Outdated Show resolved Hide resolved
code/game/cas_manager/datums/cas_fire_envelope.dm Outdated Show resolved Hide resolved
code/game/cas_manager/datums/cas_fire_envelope.dm Outdated Show resolved Hide resolved
code/game/cas_manager/datums/cas_fire_mission.dm Outdated Show resolved Hide resolved
code/game/cas_manager/datums/cas_fire_envelope.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft April 24, 2024 03:12
@cuberound cuberound marked this pull request as ready for review April 30, 2024 08:08
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the timing feels better now. Ultimately it goes off faster, but the last warning actually occurs before rather than as the first volley hits.

FM2.mp4

@Drulikar Drulikar added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. and removed Feature Feature coder badge labels May 1, 2024
@Drulikar Drulikar enabled auto-merge May 1, 2024 08:38
@Drulikar Drulikar added this pull request to the merge queue May 1, 2024
Merged via the queue into cmss13-devs:master with commit 644020a May 1, 2024
26 checks passed
cm13-github added a commit that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants