Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase damage of standard revolver ammo from 55 to 72 #6123

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Apr 9, 2024

About the pull request

After some testing from myself on a private server and gathering a lot of feedback from a post i made on the forum.
https://forum.cm-ss13.com/t/m44-rework-making-this-handgun-potent-and-unique-already-unique-in-uscm-weapon/6917
i think M44 is very cool buy lack damage output as an handgun if comparison to all the other handguns.

why 72 ? because it allow to kill a drone with a full mag and a runner with three bullet (if you manage to hit them)
it balance itself with the low mag capacity and the lower firing speed of it.

Explain why it's good for the game

because the M44 is cool to use but i also want it to make it a decent pick if you want to use an handgun.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Increase damage of standard revolver ammo from 55 to 72.
balance: Marksman ammo remains 55 damage.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Apr 9, 2024
@Huffie56 Huffie56 marked this pull request as ready for review April 9, 2024 19:24
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 17, 2024
@ihatethisengine
Copy link
Contributor

Marksman bullet is a child of regular bullet that inherits the regular's damage. Increasing regular bullet damage to 72 will increase marksman bullet damage too. Marksman bullet has 35 AP (base crusher has 35 armor), so this is an insane buff. I suggest overriding marksman damage back to 55.

@Huffie56 Huffie56 marked this pull request as draft April 17, 2024 07:56
@Huffie56 Huffie56 marked this pull request as ready for review April 17, 2024 10:38
@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Apr 18, 2024
@Drulikar Drulikar changed the title [BALANCE]Increase damage of standart revolver ammo from 55 to 72. Increase damage of standard revolver ammo from 55 to 72 Apr 20, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Apr 20, 2024
@Drulikar Drulikar added this pull request to the merge queue Apr 20, 2024
Merged via the queue into cmss13-devs:master with commit 45b9090 Apr 20, 2024
30 checks passed
cm13-github added a commit that referenced this pull request Apr 20, 2024
@Huffie56 Huffie56 deleted the revolver branch April 20, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants