Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

white phosphorus smoke can no longer override stronger flames #6137

Merged
merged 9 commits into from
Apr 20, 2024

Conversation

iloveloopers
Copy link
Contributor

@iloveloopers iloveloopers commented Apr 12, 2024

About the pull request

white phosphorus smoke will no longer forcefully set the reagent of the mob

Explain why it's good for the game

when hit by a WP rocket, a mob is supposed to be set with the blueflame reagent but sometimes the phosphorus smoke can override it just as you leave the fire and the mob's fire reagent ends up being normal UT napalm, which is signficantly weaker than blueflame.

Testing Photographs and Procedure

yes I tested it

Changelog

🆑
fix: White phosphorus will no longer forcefully set a mob's fire_reagent to be UT napthal
/:cl:

@github-actions github-actions bot added the Removal snap label Apr 12, 2024
@ihatethisengine
Copy link
Contributor

just make it a regular smoke? Otherwise it's a balance change because it makes a lot easier to follow up on WP.

@iloveloopers
Copy link
Contributor Author

just make it a regular smoke? Otherwise it's a balance change because it makes a lot easier to follow up on WP.

done

@PhantomEpicness
Copy link
Contributor

how about you fix the overriding instead of nerfing WP rockets

@ihatethisengine
Copy link
Contributor

how about you fix the overriding instead of nerfing WP rockets

how is this a nerf

@fira
Copy link
Member

fira commented Apr 14, 2024

why not just fix the phosphorous smoke?

@iloveloopers iloveloopers changed the title Removes the white phosphorus smoke from WP rockets white phosphorus smoke can no longer override stronger flames Apr 14, 2024
@iloveloopers
Copy link
Contributor Author

why not just fix the phosphorous smoke?

is this good enough?

@fira
Copy link
Member

fira commented Apr 15, 2024

Oh yeah that works i think

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Counter-intuitive that the proc works that way but works.

@Drulikar Drulikar added this pull request to the merge queue Apr 20, 2024
Merged via the queue into cmss13-devs:master with commit c517ea7 Apr 20, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Apr 20, 2024
@iloveloopers iloveloopers deleted the WP-rocket branch May 7, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants