Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds medlinks to WO and ground maps #6180

Merged
merged 1 commit into from
May 1, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Apr 22, 2024

About the pull request

This PR is a follow up to #5677 assuming changes from #6103 adding a medlink to each ground map as well as medlinks for the WO main base.

The other map changes are just the result of StrongDMM's sanitize variables setting where it deletes var edits that match what the type already has initially.

Explain why it's good for the game

Helps establish colony medbays as a temporary objective that can help the groundside operation with medical supplies. Some maps this is more practical than others, but the medlinks need to not be too close to a landing zone else it is too hard to contest them.

As far as WO, there isn't a shipside medical so the main base instead should serve that purpose.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Drathek
maptweak: Added medlinks to WO
maptweak: Added a medlink to each ground map
/:cl:

@Drulikar Drulikar requested a review from Nanu308 as a code owner April 22, 2024 01:46
@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Apr 22, 2024
@Drulikar Drulikar added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. labels Apr 22, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 30, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels May 1, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label May 1, 2024
@Nanu308 Nanu308 added this pull request to the merge queue May 1, 2024
Merged via the queue into cmss13-devs:master with commit 532f7c6 May 1, 2024
28 checks passed
cm13-github added a commit that referenced this pull request May 1, 2024
@Drulikar Drulikar deleted the Map_Medlinks branch May 1, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Stale Exempt PR can't go stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants