Data detector tweaks #6194
Merged
Data detector tweaks #6194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Quality of Life
fira
reviewed
Apr 26, 2024
Drulikar
requested changes
May 3, 2024
Drulikar
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Makes it so that empty vial boxes don't trigger a data detector ping.
Also makes it so that empty randomchem vials don't trigger a data detector ping.
The former is a bugfix as there is already (non-functional) code in place to try and achieve this result (see: #3595).
The latter is not a bugfix, but I believe fits nicely into this PR.
Note that this will still ping vial boxes containing empty vials. However, I believe this is a fine outcome since there is a low chance for a vial box to spawn with only empty vials, and I do believe those should still be pinged until someone checks and empties them.
Explain why it's good for the game
There's no reason for empty vial boxes or emptied vials to show up on the data detector.
Fixing non-functional code is good.
Testing Photographs and Procedure
Testing Evidence
Shows that both the intended result of this PR has been achieved and that nothing else regarding the detector has regressed in the process.
https://streamable.com/c7hyn6
Changelog
🆑
qol: Emptied randomchem vials no longer show up on the data detector
fix: Fixes empty vial storage boxes showing up on the data detector
/:cl: