ceil(x) conversion for 515 #6262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Changelog
harryob
added
Code Improvement
github-actions
bot
added
the
Missing Changelog
Drulikar
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
https://www.byond.com/docs/ref/#/proc/ceil
With the move to 515, removes these two defines in favor of
ceil(x):#define ROUND_UP(x) ( -round(-(x)))#define Ceiling(x) (-round(-(x)))Also converts the two-argument
CEILING(x, y)to useceilinternally.Explain why it's good for the game
Less bespoke code means less points of failure.
Testing Photographs and Procedure
Boots without obvious issue.
Changelog
No player-facing changes.