block() syntax refactor for 515 #6265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Changelog
Zonespace27
approved these changes
May 10, 2024
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Drulikar
added
Testmerge Candidate
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
added a commit
that referenced
this pull request
May 10, 2024
cm13-github
added a commit
that referenced
this pull request
May 10, 2024
cm13-github
added a commit
that referenced
this pull request
May 10, 2024
cm13-github
added a commit
that referenced
this pull request
May 10, 2024
fira
approved these changes
May 11, 2024
Drulikar
added
Code Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
https://www.byond.com/docs/ref/#/proc/block
With the move to 515, updates the
turf.dmdefines to make use of the newblock()syntax, removing unnecessarylocate()calls. Removed the out-of-bounds guards as Lummox's post implies it is no longer necessary and there were no issues in testing.Reviewed existing use of
block()or the defines. Removedlocate()anywhere it was no longer necessary due to the new syntax. Switched to the defines where helpful. Anyforloop using the turf list was changed tovar/turf/... as anything...if there would be no side effects.Explain why it's good for the game
Making full use of new functionality. More consistent use of
block(). Fewer calls tolocate()and more use ofas anythingcan't hurt.Testing Photographs and Procedure
Boots without obvious issue. Checked Almayer and LV624, both look generated correctly. Shuttles launch and land correctly. Vehicles collide correctly.
Changelog
No player-facing changes.