round(x) deprecation for 515 #6281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Changelog
Drulikar
requested changes
May 14, 2024
code/modules/lighting/lighting_static/static_lighting_corner.dm
Outdated
Show resolved
Hide resolved
Drulikar
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
https://www.byond.com/docs/ref/#/proc/round
With the move to 515, replaces any use of the one-argument
round(x)withfloor(x).Explain why it's good for the game
floor(x)clearly communicates what is actually happening, as opposed toround(x)which doesn't.Testing Photographs and Procedure
Boots without obvious issue.
Changelog
No player-facing changes.