Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

round(x) deprecation for 515 #6281

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

Doubleumc
Copy link
Contributor

@Doubleumc Doubleumc commented May 13, 2024

About the pull request

image

The first format returns the floor of A (the largest integer less than or equal to A), and has been deprecated in favor of floor(A).

https://www.byond.com/docs/ref/#/proc/round

With the move to 515, replaces any use of the one-argument round(x) with floor(x).

Explain why it's good for the game

floor(x) clearly communicates what is actually happening, as opposed to round(x) which doesn't.

Testing Photographs and Procedure

Boots without obvious issue.

Changelog

No player-facing changes.

@Doubleumc Doubleumc requested a review from fira as a code owner May 13, 2024 02:44
@github-actions github-actions bot added the Missing Changelog Maintainers always document their changes. label May 13, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks correct.

@Drulikar Drulikar marked this pull request as draft May 14, 2024 11:48
@Doubleumc Doubleumc marked this pull request as ready for review May 15, 2024 01:39
@Drulikar Drulikar added this pull request to the merge queue May 15, 2024
Merged via the queue into cmss13-devs:master with commit a136f35 May 15, 2024
28 checks passed
@Doubleumc Doubleumc deleted the round-deprecation branch May 15, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing Changelog Maintainers always document their changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants