Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds & adjusts fireman skills for most roles. #6339

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

BasilHerb
Copy link
Contributor

@BasilHerb BasilHerb commented May 27, 2024

About the pull request

This PR aims to add BASIC fireman carry skills to the overwhelming majority of roles in CM. It adds more advanced fireman skills to select roles, such as SLs and highly trained personnell such as deathsquad commandos. It also modifies some out-of-place fireman skills and changes them to stay in line.

I have tested my changes with no issue in the T-Dome. Fireman carry does indeed work for the one's I've changed, though I cannot say for sure I didn't miss a few roles (approx 70-ish roles total). I did not experience any bugs or glitches during the process.

Explain why it's good for the game

It is absolutely WILD that people can pass basic marine training and STILL not be able to carry another marine's weight over their backs. The average CLF guerilla has Fireman Skill TWO, whereas the average USCM rifleman has none at all. It's simply quite jarring to see this.

In addition, CLF medics and engineers have no fireman skill either- There is a significant disparity between fireman carry skills, and so this PR has corrected them to be more in line (e.g. CLF soldier, medic & engineer now have fireman 1).

Other, more advanced factions such as the super-trained Bri'ish and W-Y PMCs have skilled fireman carries already (Hell, even VAIPO contractors have it). It's simply a logical step to give the USCM basic fireman carrying skills.

There will of course, be concerns of balance- Will adding fireman carry to your average marine affect gameplay balance significantly?

In my opinion, it's an obvious 'no'. Fireman carrying is a NICHE skill. At the basic level, it is more efficient AND safe to simply drag a downed marine 6 tiles to a medic than to spend 3 seconds standing still (easy target) to carry them first.

Fireman carrying is a skill intended for long-hauls. The vast majority of casualties need only be dragged less than one screen away to a medic. Circumstances where you fireman carry someone all the way to FOB are much rarer.

In addition, fireman carrying and dragging are both completely and utterly outshined by roller beds- A tool which any marine can use and carry, a tool which can be pre-primed such that you can INSTANTLY put a marine on a bed and run off at Mach 7 before a xeno can say 'Mommy'. Roller beds are already commonly used to great effect, and as such fireman carrying will remain a niche tool that will not significantly impact the round.

I hope this PR can be testmerged to get a feel for whether it will be suitable for the game. I suspect the number of roles who get the skill may be too much, but at the very least I'm hoping for enlisted frontline USCM & UPP personnel to gain the skill.

Testing Photographs and Procedure

Screenshot 2024-05-27 152425

Changelog

/:cl:
add: Fireman carry to any roles that didn't already have them, except for colony civilians.
balance: Nerfed CLF Guerilla fireman carry from Skilled to Trained.
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Missing Changelog Maintainers always document their changes. labels May 27, 2024
@Skatuk
Copy link

Skatuk commented May 27, 2024

Leave CLF fireman skill as it is since it fits their background quite nicely. CLF lacks in budget but makes up with skills

@neeshacark
Copy link
Contributor

as much as i would love this i feel like its going to get shot down over balance concerns (though i agree with you that it wont be as big of a deal as certain people make it out to be)

code/datums/skills/civilian.dm Outdated Show resolved Hide resolved
code/datums/skills/civilian.dm Outdated Show resolved Hide resolved
code/datums/skills/misc.dm Outdated Show resolved Hide resolved
code/datums/skills/upp.dm Outdated Show resolved Hide resolved
code/datums/skills/upp.dm Outdated Show resolved Hide resolved
code/datums/skills/uscm.dm Outdated Show resolved Hide resolved
code/datums/skills/uscm.dm Outdated Show resolved Hide resolved
code/datums/skills/uscm.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft May 28, 2024 00:38
@Drulikar
Copy link
Contributor

Changelog is also malformed, thats why you have the Missing Changelog tag. You need /:cl:

@github-actions github-actions bot added Missing Changelog Maintainers always document their changes. and removed Missing Changelog Maintainers always document their changes. labels May 30, 2024
@github-actions github-actions bot removed the Missing Changelog Maintainers always document their changes. label May 31, 2024
@BasilHerb BasilHerb marked this pull request as ready for review May 31, 2024 13:29
code/datums/skills/uscm.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jun 3, 2024
@Drulikar Drulikar enabled auto-merge June 3, 2024 16:21
@Drulikar Drulikar added this pull request to the merge queue Jun 3, 2024
Merged via the queue into cmss13-devs:master with commit f39be47 Jun 3, 2024
27 checks passed
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Jun 9, 2024
# About the pull request
This PR aims to add BASIC fireman carry skills to the overwhelming
majority of roles in CM. It adds more advanced fireman skills to select
roles, such as SLs and highly trained personnell such as deathsquad
commandos. It also modifies some out-of-place fireman skills and changes
them to stay in line.

I have tested my changes with no issue in the T-Dome. Fireman carry does
indeed work for the one's I've changed, though I cannot say for sure I
didn't miss a few roles (approx 70-ish roles total). I did not
experience any bugs or glitches during the process.

# Explain why it's good for the game

It is absolutely WILD that people can pass basic marine training and
STILL not be able to carry another marine's weight over their backs. The
average CLF guerilla has Fireman Skill *TWO*, whereas the average USCM
rifleman has none at all. It's simply quite jarring to see this.

In addition, CLF medics and engineers have no fireman skill either-
There is a significant disparity between fireman carry skills, and so
this PR has corrected them to be more in line (e.g. CLF soldier, medic &
engineer now have fireman 1).

Other, more advanced factions such as the super-trained Bri'ish and W-Y
PMCs have skilled fireman carries already (Hell, even VAIPO contractors
have it). It's simply a logical step to give the USCM basic fireman
carrying skills.

There will of course, be concerns of balance- Will adding fireman carry
to your average marine affect gameplay balance significantly?

In my opinion, it's an obvious 'no'. Fireman carrying is a NICHE skill.
At the basic level, it is more efficient AND safe to simply drag a
downed marine 6 tiles to a medic than to spend 3 seconds standing still
(easy target) to carry them first.

Fireman carrying is a skill intended for long-hauls. The vast majority
of casualties need only be dragged less than one screen away to a medic.
Circumstances where you fireman carry someone all the way to FOB are
much rarer.

In addition, fireman carrying and dragging are both completely and
utterly outshined by roller beds- A tool which any marine can use and
carry, a tool which can be pre-primed such that you can INSTANTLY put a
marine on a bed and run off at Mach 7 before a xeno can say 'Mommy'.
Roller beds are already commonly used to great effect, and as such
fireman carrying will remain a niche tool that will not significantly
impact the round.

I hope this PR can be testmerged to get a feel for whether it will be
suitable for the game. I suspect the number of roles who get the skill
may be too much, but at the very least I'm hoping for enlisted frontline
USCM & UPP personnel to gain the skill.

# Testing Photographs and Procedure

![Screenshot 2024-05-27
152425](https://github.com/cmss13-devs/cmss13/assets/168701329/f499ecc4-1dc8-4c04-b9c3-b52442406726)


# Changelog

/:cl:
add: Fireman carry to any roles that didn't already have them, except
for colony civilians.
balance: Nerfed CLF Guerilla fireman carry from Skilled to Trained.
/:cl:

---------

Co-authored-by: Drathek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants