Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID Mod computer biometrics #6355

Closed

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Jun 1, 2024

About the pull request

This PR adds a biometric check for LOGGING IN to an id mod computer. This will not prevent people from pressing buttons whilst another person is already logged in, but will prevent use of an invalid or stolen ID.

Explain why it's good for the game

Primary change this will make is stopping ERTs from bypassing the deliberate no-access they have to cancel Evac and similar actions in CIC. This is not intended to prevent people sneaking access onto their cards whilst someone else legitimately logged in to the console.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added a biometric check to the initial authentication part of ID Modification consoles.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jun 1, 2024
@vero5123
Copy link
Contributor

vero5123 commented Jun 1, 2024

Gotta fix the indentation... GitHub editor :/

@JackieEstegado
Copy link
Contributor

This will also stop people from getting access when only few people are left alive and want to initiate evac for pods.
Just do a faction check if you want to prevent ERTs from doing it.

cm13-github added a commit that referenced this pull request Jun 3, 2024
@Skatuk
Copy link

Skatuk commented Jun 3, 2024

So your doing this to stop evac being cancelled? When you can give it a cooldown or the requirement of USCM faction or hell even make it so they can't toggle it mechanically? I'm against the force of biometrics.

The deliberate in game no access for ERT's makes it so they have to scavange command ID's since it makes no sense IC how CLF have direct access to CIC (Exception being the technician) also scavenging ID's permits them the ability to gain IFF so they can actually attack defences with the limited numbers they have.

cm13-github added a commit that referenced this pull request Jun 3, 2024
@Diegoflores31
Copy link
Contributor

Just for future clarification . Killing someone WITH access and using their ID to cancel evac would be then Valid game ?

cm13-github added a commit that referenced this pull request Jun 4, 2024
cm13-github added a commit that referenced this pull request Jun 4, 2024
cm13-github added a commit that referenced this pull request Jun 4, 2024
@realforest2001
Copy link
Member Author

Just for future clarification . Killing someone WITH access and using their ID to cancel evac would be then Valid game ?

You already can't use someone elses ID to cancel evac. The issue this PR is trying to address is that people have been bypassing that by using someone elses ID to modify their own.

@realforest2001
Copy link
Member Author

This will also stop people from getting access when only few people are left alive and want to initiate evac for pods. Just do a faction check if you want to prevent ERTs from doing it.

I'm considering this currently, as it would be a better idea I agree.

cm13-github added a commit that referenced this pull request Jun 4, 2024
cm13-github added a commit that referenced this pull request Jun 4, 2024
cm13-github added a commit that referenced this pull request Jun 4, 2024
cm13-github added a commit that referenced this pull request Jun 6, 2024
cm13-github added a commit that referenced this pull request Jun 6, 2024
cm13-github added a commit that referenced this pull request Jun 6, 2024
cm13-github added a commit that referenced this pull request Jun 6, 2024
cm13-github added a commit that referenced this pull request Jun 6, 2024
cm13-github added a commit that referenced this pull request Jun 6, 2024
@GrrrKitten GrrrKitten mentioned this pull request Jun 12, 2024
3 tasks
cm13-github added a commit that referenced this pull request Jun 13, 2024
cm13-github added a commit that referenced this pull request Jun 13, 2024
cm13-github added a commit that referenced this pull request Jun 14, 2024
cm13-github added a commit that referenced this pull request Jun 14, 2024
cm13-github added a commit that referenced this pull request Jun 16, 2024
cm13-github added a commit that referenced this pull request Jun 16, 2024
cm13-github added a commit that referenced this pull request Jun 16, 2024
cm13-github added a commit that referenced this pull request Jun 16, 2024
cm13-github added a commit that referenced this pull request Jun 16, 2024
@Harrysno Harrysno mentioned this pull request Jun 17, 2024
3 tasks
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jun 19, 2024
@Drulikar
Copy link
Contributor

Stale exempt until reviewed

@harryob
Copy link
Member

harryob commented Jul 9, 2024

This will also stop people from getting access when only few people are left alive and want to initiate evac for pods. Just do a faction check if you want to prevent ERTs from doing it.

I'm considering this currently, as it would be a better idea I agree.

we should do this - re-open when you want to make these changes

@harryob harryob closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale Exempt PR can't go stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants