-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event Spawn: Synthetic K9 Rescue Teams #6490
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ALSO THIS IS MY FIRST SERIOUS FULL FEATURE EVER. I APPOLOGIZE FOR ANY SHIT CODE OR PAINFUL STRESS CAUSED TO MAINTAINERS FOR VIEWING MY HAMFISTED CODE ATTEMPT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comment on dogs being human subtypes
if (istype(species, /datum/species/monkey)) //Point towards burning sprites for monkeys | ||
fire_sprite_sheet = 'icons/mob/humans/onmob/OnFire.dmi' | ||
fire_sprite_prefix = "monkey" | ||
else if (istype(species, /datum/species/synthetic/synth_k9)) //Point towards burning sprites for k9_synths | ||
fire_sprite_sheet = 'icons/mob/humans/onmob/OnFire.dmi' | ||
fire_sprite_prefix = "k9" | ||
else //Default to human shaped fire sprites | ||
fire_sprite_sheet = 'icons/mob/humans/onmob/OnFire.dmi' | ||
fire_sprite_prefix = "Standing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be species vars
Co-authored-by: Zonespace <[email protected]>
Co-authored-by: Zonespace <[email protected]>
Co-authored-by: Vero <[email protected]>
Co-authored-by: Vero <[email protected]>
Co-authored-by: Vero <[email protected]>
Co-authored-by: Vero <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few more nits
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
About the pull request
Adding a full gameplay loop of the Synthetic K9s that have been historically run by Admins, except as a full fledged Species and Job set that way it's much easier to set up, requires no oversight (the process was originally a 20 minute set up and then needed to be baby sat every time the K9 would be damaged).
The gameplay loop is this:
Features for this include:
Additional Improvements include:
Sound Notes:
Sprite Notes:
K9 sprite based on the coyote from mojave sun
Explain why it's good for the game
This gives the K9 Synth rescue team a full gameplay loop, good player engagement, helps bolster RP while also making an event that isn't goofy or silly.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑
add: Added Synthetic K9 Rescue Teams
fix: Monkeys no longer have access to marine emotes AND now have access to their own emotes but were blocked from.
code: Added a NO_OVERLAYS flag for species should we ever want a species to not use onmob overlays.
refactor: Altered emote whitelisting and blacklisting so that species that were blacklisted out of the basic emotes will able to be whitelisted for other emotes
soundadd: added dog sounds for Synthetic K9 Rescue Teams
imageadd: added icons for Synthetic K9 Rescue Teams
/:cl: