Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Floors for 6312 Soro Strata APC #6499

Conversation

hislittlecuzingames
Copy link
Contributor

@hislittlecuzingames hislittlecuzingames commented Jun 17, 2024

About the pull request

Fixes #6312

Explain why it's good for the game

Allows APC to be fixed/worked on

Testing Photographs and Procedure

🫠

Took floor tile from Desert_Dam where an APC was and just selected a different colour sprite that seemed like it looked nice.

Changelog

🆑
fix: Adds Floors that can allow APC to be fixed on Soro Comms 2 near south LZ
maptweak: Soro APC Comms 2 floor fixed
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Jun 17, 2024
@hislittlecuzingames hislittlecuzingames marked this pull request as ready for review June 17, 2024 18:27
@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jun 17, 2024
@hislittlecuzingames
Copy link
Contributor Author

If any spriters are interested in making this look nicer, the desert dam sand sprites in white would be pretty neato.
/ideasguy

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 25, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please instead consider making it like the other external APCs rather than randomly purple edged tiles. E.g.
image

Doubly so because when the tile(s) get replaced by marines they will no longer be purple.
image

@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Jun 27, 2024
@Drulikar Drulikar marked this pull request as draft June 27, 2024 03:53
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 8, 2024
@github-actions github-actions bot closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Mapping did you remember to save in tgm format? Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a apc that cant be fixed
2 participants