Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a apc that cant be fixed #6312

Closed
3 tasks done
tzTZtzTZqwq opened this issue May 19, 2024 · 3 comments · Fixed by #6686
Closed
3 tasks done

a apc that cant be fixed #6312

tzTZtzTZqwq opened this issue May 19, 2024 · 3 comments · Fixed by #6686
Labels
Bug Admin events aren't bugs Mapping did you remember to save in tgm format?

Comments

@tzTZtzTZqwq
Copy link

Testmerges

Round ID

No response

Description of the bug

o fix the apc the wire needs to be removed
to remove the wire the floor need to be removed
but theres no floor
so the wire cant be removed
so the apc cant be fixed
b3decc0248f2d65429e8ec2edafca889cc3de1ed
6ee068431df6f8598f8a1203f42143ad34bd4251

What's the difference with what should have happened?

there should be a floor and wire on that tile so the wire can be removed

How do we reproduce this bug?

the location of the comms is marked on the img

Issue Bingo
@tzTZtzTZqwq tzTZtzTZqwq added the Bug Admin events aren't bugs label May 19, 2024
@hislittlecuzingames
Copy link
Contributor

Good first issue

@Diegoflores31
Copy link
Contributor

Mapping Issue Tag @Huffie56

@hislittlecuzingames hislittlecuzingames mentioned this issue Jun 17, 2024
Closed
@hislittlecuzingames
Copy link
Contributor

#6499

@Huffie56 Huffie56 added the Mapping did you remember to save in tgm format? label Jun 18, 2024
@Venuska1117 Venuska1117 mentioned this issue Aug 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 7, 2024
@Venuska1117 @Blundir
Re: Add Directional APC's sprites, reduces lines of code by adding an…
275837d 
…d using Updatepaths.txt file. (#6686)

# About the pull request

This PR add directional APC's and Updatepath.txt

standardize APC's by creating 2 separate types, normal and upgraded
variant, replace APC's with cell types: high/super/hyper with upgraded
variant with own HIGH cell type. (10000 capacity)

Edit: Add directional APC sptires made by Blundir.

Fixes: #6792
Fixes: #6312

# Explain why it's good for the game

Reduces lines of codes in mapping, i know there is already code in
apc.dm to make them have pixel_y or pixel_x offset.

Mainly issue is: in map editor they have var edited offsets, with mean
it not only override code that already exist, but also occupy more
space, with new code it should do same in exchange for less lines of
code. (i didnt remove directional code for other stuff like broken APC's
etc.)

Edit: Add directional APC's sprites for better visuals

# Testing Photographs and Procedure
New directional APC's sprites by @Blundir.

![image](https://github.com/user-attachments/assets/aeca90ef-fa07-4907-8b35-6a1eb0a334ea)

Image from Blundir:

![image](https://github.com/user-attachments/assets/5780bcf0-cb33-467e-9617-172ca6427322)



# Changelog
:cl: Venuska1117, Blundir
imageadd: add directional APC's Sprites.
balance: Now there are only 3 APC's types, APC's with call_type
high/super/hyper are replaced with upgraded APC variant containing high
capacity cell, weak variant got replaced with normal APC variant.
fix: Fixes APC's with wrong offsets (strata and Prison)
/:cl:

---------

Co-authored-by: Blundir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs Mapping did you remember to save in tgm format?
Projects
None yet
Milestone
No milestone
4 participants
@Diegoflores31 @tzTZtzTZqwq @Huffie56 @hislittlecuzingames