Re: Add Directional APC's sprites, reduces lines of code by adding and using Updatepaths.txt file. #6686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mapping
Venuska1117
changed the title
Venuska1117
changed the title
github-actions
bot
added
Sprites
|
Mapping assets premade in code? Meh, good idea? |
This comment was marked as resolved.
This comment was marked as resolved.
Sprites 2
- Revert changes to Updatepath file. - Change name of Updatepath file to match PR number. - Fixed direction of New APC's sprites. - Modify changes made to apc.dm to match sprites direction.
Venuska1117
changed the title
Nanu308
previously requested changes
Jul 18, 2024
yeah, the new checking system did not allow me to commit, beacause there were duplicated APC's, nanomeds etc. i will double check to be sure. |
Drulikar
requested changes
Aug 1, 2024
Drulikar
added
the
Testmerge Candidate
Venuska1117
force-pushed
the
apc-updatepath
branch
from
262538f
to
dc6509a
Compare
Drulikar
requested changes
Aug 6, 2024
Drulikar
added
the
Balance Approved
Drulikar
approved these changes
Aug 7, 2024
Drulikar
dismissed
Nanu308’s stale review
All diffs where the APC moves off the diff is just an issue with map diff bot; all appear fine in strongdmm and in game
cm13-github
added a commit
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR add directional APC's and Updatepath.txt
standardize APC's by creating 2 separate types, normal and upgraded variant, replace APC's with cell types: high/super/hyper with upgraded variant with own HIGH cell type. (10000 capacity)
Edit: Add directional APC sptires made by Blundir.
Fixes: #6792
Fixes: #6312
Explain why it's good for the game
Reduces lines of codes in mapping, i know there is already code in apc.dm to make them have pixel_y or pixel_x offset.
Mainly issue is: in map editor they have var edited offsets, with mean it not only override code that already exist, but also occupy more space, with new code it should do same in exchange for less lines of code. (i didnt remove directional code for other stuff like broken APC's etc.)
Edit: Add directional APC's sprites for better visuals
Testing Photographs and Procedure
New directional APC's sprites by @Blundir.
Image from Blundir:
Changelog
🆑 Venuska1117, Blundir
imageadd: add directional APC's Sprites.
balance: Now there are only 3 APC's types, APC's with call_type high/super/hyper are replaced with upgraded APC variant containing high capacity cell, weak variant got replaced with normal APC variant.
fix: Fixes APC's with wrong offsets (strata and Prison)
/:cl: