Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OD lint errors #6566

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix OD lint errors #6566

merged 1 commit into from
Jun 27, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jun 26, 2024

About the pull request

This PR fixes these messages for the OD lint:

Warning OD1002 at code/__pragmas.dm:15:26: Warning 'TooManyArguments' does not exist
Error OD0000 at code/datums/global_variables.dm:127:30: attempt to reference r-value
Error OD0000 at code/datums/global_variables.dm:369:44: attempt to reference r-value

TooManyArguments was replaced with InvalidArgumentCount which should already be an error. The other two errors are regarding initial not working on globals, which it does not appear to.

Explain why it's good for the game

Passing checks is good.

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

No player facing changes.

@github-actions github-actions bot added the Missing Changelog Maintainers always document their changes. label Jun 26, 2024
@harryob harryob added this pull request to the merge queue Jun 27, 2024
Merged via the queue into cmss13-devs:master with commit efb0858 Jun 27, 2024
28 checks passed
@Drulikar Drulikar deleted the Fix_Globals_Lint branch June 27, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing Changelog Maintainers always document their changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants