Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The great research hugboxing #6625

Closed
wants to merge 4 commits into from

Conversation

iloveloopers
Copy link
Contributor

@iloveloopers iloveloopers commented Jul 5, 2024

About the pull request

removes the ability to buy clearance papers
clearance cards now give credits instead
cards no longer lose their value when scanned by the wrong person

Explain why it's good for the game

less opportunities for bald researchers to waste the team's hard earned credits

Testing Photographs and Procedure

i tested it and it works

Changelog

🆑
del: Removed ability to buy clearance papers.
balance: Clearance cards now give their equivalent clearance in credits.
balance: Clearance cards no longer lose their value when scanned by the wrong person.
/:cl:

@github-actions github-actions bot added UI deletes nanoui/html Removal snap Quality of Life Make the game harder to play labels Jul 5, 2024
@TheManWithNoHands
Copy link
Contributor

Dont remove buying chem papers. It can often come in clutch when IOs already piked the colonie clean.
Great source of legendary propertys.

Dont remove tools just because some dont know how to use it.

@iloveloopers
Copy link
Contributor Author

Right, because rolling the dice on RNG clearance papers in hopes of getting a legendary is peak game design. 99% of the time they aren't bought at all and the 1% is bald researchers screwing up their team by wasting credits on it.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added Stale beg a maintainer to review your PR Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Jul 14, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jul 14, 2024
code/game/machinery/computer/research.dm Outdated Show resolved Hide resolved
code/game/machinery/computer/research.dm Outdated Show resolved Hide resolved
code/game/machinery/computer/research.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Jul 14, 2024
@Drulikar Drulikar marked this pull request as draft July 14, 2024 05:43
@iloveloopers iloveloopers marked this pull request as ready for review July 14, 2024 19:11
@iloveloopers
Copy link
Contributor Author

its jover

github-merge-queue bot pushed a commit that referenced this pull request Aug 5, 2024
# About the pull request

This PR revives #6625 

# Explain why it's good for the game

More intuitive credit reward for research getting a survivor to swipe
their card so there isn't a meta strategy for the best utilization of
credits. Now at most 47 credits can be awarded (for a manager survivor's
card; only allowed to be swiped by them) regardless of whatever the
current research clearance is at.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl: Drathek iloveloopers
del: Removed ability to buy clearance papers.
balance: Clearance cards now give their equivalent clearance in credits.
balance: Clearance cards no longer lose their value when scanned by the
wrong person.
/:cl:

---------

Co-authored-by: iloveloopers <[email protected]>
Co-authored-by: iloveloopers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Quality of Life Make the game harder to play Removal snap UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants