Bumps Python version because it refuses to work #6654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… version TG uses when they first introduced maplint.
github-actions
bot
added
the
Missing Changelog
6 tasks
harryob
approved these changes
Jul 8, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
# About the pull request This PR updates Maplint and UpdatePaths effectively porting these PRs: - tgstation/tgstation#75892 for the `@ANY` functionality - tgstation/tgstation#73528 for the fix to error help messages in maplint - tgstation/tgstation#79394 for the fix preventing duplicates New lints: - [X] When a maplint bans all var edits, it now suggests UpdatePath lines and dm code suggestions. Var edits for things other than dir or icon_state likely need to have the suggested typepath amended. - [X] All dirs are checked to be valid for any obj, turf, or mob in a map. - [x] No var edits for turf/open because ScrapeAway will just revert any map var edits (e.g. when a xeno builds a resin wall on a turf and that wall later is destroyed) - [X] No duplicate machines in the same tile: tgstation/tgstation#79394 - [X] No duplicate windows in the same tile: tgstation/tgstation#79487 - [X] No items in closed walls: tgstation/tgstation#77308 Also of note, this PR requires: #6654 so that line change is also incorporated in this PR. But I expect this to take a while for mapping review so made a separate PR for it alone that I can just resolve the conflict for here. # Explain why it's good for the game Prevents issues like this where the center turfs were rotated (reset):  Fixes turfs resetting: https://github.com/cmss13-devs/cmss13/assets/76988376/5112e52b-7d3c-4739-a5a1-1c6115945889 # Testing Photographs and Procedure See https://github.com/cmss13-devs/cmss13/actions/runs/9873200755/job/27264944601#step:7:1187 for an example of the maplint suggestions. <details> <summary>Screenshots & Videos</summary> https://github.com/cmss13-devs/cmss13/assets/76988376/b6f891e0-1446-434e-a84d-f007f1851007 </details> # Changelog :cl: Drathek maptweak: Removed var edits from open turfs to fix ScrapeAway resetting the turf (e.g. xenos building resin walls) on basically all maps maptweak: Fixed bad dir var edits on various map maptweak: Fixed stacked structures on various maps /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Python some reason refuses to run scripts using 3.7 now. This bumps it to version TG uses when they first introduced maplint.
Of note it may be necessary for contributors to run either bootstrap\python.bat or tools\hooks\install.bat to have their tools working again.
Explain why it's good for the game
Fixes
Testing Photographs and Procedure
Screenshots & Videos
Hooks install:
Changelog
No player facing changes.