Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes hunter games code #6659

Closed
wants to merge 1 commit into from

Conversation

Zonespace27
Copy link
Contributor

@Zonespace27 Zonespace27 commented Jul 8, 2024

About the pull request

Removes all code associated with hunter games.

Explain why it's good for the game

The gamemode is entirely broken and hasn't been properly touched in years. If someone wants to rework it, they can readd the code then. In the meantime, I'm removing the code to make adding the OD3203 pragma easier.

@github-actions github-actions bot added the Missing Changelog Maintainers always document their changes. label Jul 8, 2024
@Zonespace27 Zonespace27 marked this pull request as draft July 8, 2024 06:56
@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Jul 8, 2024
@Zonespace27 Zonespace27 marked this pull request as ready for review July 8, 2024 07:05
@Zonespace27 Zonespace27 requested a review from Nanu308 as a code owner July 8, 2024 07:05
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 10, 2024
@Zonespace27 Zonespace27 requested a review from fira as a code owner July 16, 2024 14:13
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jul 16, 2024
@github-actions github-actions bot added Sprites Remove the soul from the game. Sound Blast 5 minutes of bass boosted music to our players UI deletes nanoui/html labels Jul 16, 2024
@Zonespace27 Zonespace27 reopened this Jul 16, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mapping changes are lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Jul 18, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 25, 2024
@Drulikar
Copy link
Contributor

See all the config errors and runtimes

@Drulikar Drulikar marked this pull request as draft July 27, 2024 13:16
@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jul 28, 2024
@Zonespace27 Zonespace27 closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Missing Changelog Maintainers always document their changes. Sound Blast 5 minutes of bass boosted music to our players Sprites Remove the soul from the game. UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants