Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successful AA interceptions now destroy the hijacked shuttle and end the round #6671

Closed

Conversation

blackdragonTOW
Copy link
Contributor

@blackdragonTOW blackdragonTOW commented Jul 10, 2024

About the pull request

Many people love to complain about hijack and how much they don't like it. What if we just removed 1/6th of hijacks?

This makes it so that if the hijack area lines up with the AA protection area, the weapon system does its job rather than politely asking the ship to turn around. The shuttle is deleted and the round ends with a Xeno Minor.

Explain why it's good for the game

An added benefit to this might make hijack location selection something other than defaulting to upper aft to pre-cog the evac attempt. And might even turn into some 4D chess with AA location setting and hijack selection trying to out maneuver what the other placed. Otherwise statistically this is a 1 in 6 chance for an intercept, assuming marines actually set AA (my god so many marines forget to set AA)

Testing Photographs and Procedure

A silly amount of hijackings to make sure the correct messages and timings are used. Really kinda learned how difficult it is to iterate at a reasonable speed.

Changelog

🆑
balance: AA intercepts during hijack now destroy the shuttle and end the round
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 10, 2024
@ihatethisengine
Copy link
Contributor

ihatethisengine commented Jul 10, 2024

I mean, unironically adding a better effect of successful AA is a neat idea. But round end and complete wipe of a side just over a roll of a dice is way too funny. At least maybe send the shuttle back to the ground so it's not that sad for xenos. And ideally it should require some kind of research upgrade, then it will be perfect.

@hislittlecuzingames
Copy link
Contributor

Finally some strategy beyond "Set AA for lifeboats."

@blackdragonTOW
Copy link
Contributor Author

Finally some strategy beyond "Set AA for lifeboats."

Exactly. And if the meta shifts do hitting lower instead, that then becomes a meta chase and there's actual strategy involved for placing AA in a rock paper scissors sense of strategy. Dare I say that putting thought into what button you're pressing is a good thing rather than slamming the same thing over and over.

@Steelpoint
Copy link
Contributor

Steelpoint commented Jul 12, 2024

If the idea of killing every Xenomorph is too excessive, you could rework it that the Almayer's AA simply shoots down the Dropship and causes it to land/crash on the planet, while also ending the round.

@blackdragonTOW
Copy link
Contributor Author

If the idea of killing every Xenomorph is too excessive, you could rework it that the Almayer's AA simply shoots down the Dropship and causes it to land/crash on the planet, while also ending the round.

What does this mechanically accomplish?

@Steelpoint
Copy link
Contributor

Steelpoint commented Jul 12, 2024

What does this mechanically accomplish?

As I wrote it accomplishes the same end-state this PR envisions, but it allows the xenomorphs to react to the events that have transpired from an in-character perspective instead of deceased ghosts. It may also make this outcome more palatable to the xenomorph players as whilst the outcome is the same they at least may not feel as negatively impacted as they were not killed.

@Drulikar
Copy link
Contributor

IMO correctly selecting an AA location is too brainless of a thing for marines to turn a losing situation around. And is also pretty lame for those who would be preparing for a fight to miss out on it from both sides. For example, xenos managing to grow a King successfully only for marines to turn tail, attempt to hijack, and just blow up without any action.

Additionally, this is far too prone to metacommunication from both sides. Either:
A) Queen can be informed where the AA location is set to.
B) Marines can be informed where to set the AA location to.
If you lock it out so it can only be set once, A then becomes likely. If you allow it to be freely changed, B is more likely. If you lock it out only after hijack, A is more likely. I'm not sure what to suggest here that would ever resolve this problem outside just removing the selection entirely and just making it RNG entirely which makes the player agency issue that much more of an issue - xenos just sometimes get robbed of a successful hijack by chance.

I'm not totally against the idea but AA up to this point has only been a means to ensure the location you intend to hold doesn't get obliterated. Maybe instead successful AA could actually shoot at the dropship, causing an explosion in the traveling shuttle spacing/gibbing those unlucky where it happens to land, but otherwise still crash lands in some other location in the ship.

Until at the very least the metacommunication issue is resolved, this is DNM.

@Drulikar Drulikar added the Do Not Merge If you merge this PR, I will annihilate you label Jul 14, 2024
@Drulikar Drulikar marked this pull request as draft July 14, 2024 05:02
@blackdragonTOW
Copy link
Contributor Author

blackdragonTOW commented Jul 14, 2024

I've updated the PR with what I feel is an elegant solution.

Firstly, allow me to remind our players that meta-gaming is a ban-able offense and can result in you being removed from the community!

This solution follows good security on how best to go about keeping any sort of meta to a minimum. Firstly, AA cannot be set until hijack has started. This means two things: 1: Only the Queen knows where the DS is going. and 2: Marines have ~60s until we check to see if AA lines up with the hijack target. (As a note: setting the AA to the correct location after that check period is up still results in a hijack impact, so late attempts will not work).

Given how there is no hive based messaging for where hijack is pointed after the Queen selects it, that means the Queen is in charge of that information and keeps it secret for the narrow time frame that it is relevant. That then means once 60-70s have passed, the Queen can share that info (or honestly, she can keep it to herself until the hijack zoom sound starts, because it's not like there's much prep to do while on the shuttle ride) and we play like nothing had changed.

And should meta-gaming happen by the Queen, it's an easy find on their ckey as we have the hijack start logged and the Queen is literally the only xeno who can start hijack.

@blackdragonTOW blackdragonTOW marked this pull request as ready for review July 14, 2024 08:08
@blackdragonTOW
Copy link
Contributor Author

Also substantially more soul in setting the AA once there's an actual incoming air threat, as well as the officer rushing to the foredeck to get there in time.

Really anything to keep people from slowly gravitating to upper-aft after FOB evac.

@Steelpoint
Copy link
Contributor

Changelog will need updating regarding the change to how setting AA is being changed.

Perhaps Marines might need a IC message alerting them to set up the AA.

@Drulikar Drulikar removed the Do Not Merge If you merge this PR, I will annihilate you label Jul 14, 2024
@Drulikar
Copy link
Contributor

If you're certain you want to go forward with this, making a limited time to select where to put AA and it relying on the queen to keep that secret is workable as far as my DNM concerns once there's a bit more messaging indicating AA is available like Steelpoint was mentioning above.

I personally still think this is worse for the game however. I would much rather xenos taking hits from AA fire and them being in worse condition on crash land than just the entire hijack part of the game to abruptly end. Hijack doesn't have to be in their favor always; but I'd rather the sequence of events to not make players feel like they got robbed of gameplay they expected.

I will be considering reverting this PR or reworking what effect AA has when https://hackmd.io/@Drathek/BywFsOfH0 is implemented.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 22, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale Testmerge Candidate we'll test this while you're asleep and the server has 10 players and removed Stale beg a maintainer to review your PR labels Jul 27, 2024
@Drulikar Drulikar added Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. and removed Stale Exempt PR can't go stale labels Aug 1, 2024
@Drulikar Drulikar marked this pull request as draft August 1, 2024 07:59
cm13-github added a commit that referenced this pull request Aug 1, 2024
cm13-github added a commit that referenced this pull request Aug 1, 2024
cm13-github added a commit that referenced this pull request Aug 2, 2024
cm13-github added a commit that referenced this pull request Aug 2, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with the change making AA only able to be set when there is a hostile dropship enroute. But merely performing intoTheSunset on the shuttle and setting xeno minor I am not comfortable with.

Please make it so the shuttle takes damage and potentially spaces any of the hive that happens to be where the AA fired onto the shuttle. I am not concerned about the hive being at full strength for a hijack, but I would like the hijack to play out, even if it by chance happened to space the entire hive.

Ultimately hijack should not be aborted, the shuttle should still crash, and it should be a spectacle while giving AA more meaning and realism.

@Drulikar Drulikar removed Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Testmerge Candidate we'll test this while you're asleep and the server has 10 players labels Aug 3, 2024
@blackdragonTOW
Copy link
Contributor Author

The intent of this PR was to skip a small number of hijacks, given that the end goal of that here would no longer be achieved, I think changing this to something else would deviate from the desired outcome of what I set out to do. Rather than turn this into something it's not I'll close it out and consider this little experiment concluded.

Also lmao 35 thumbs up, never seen it ever get that high on a PR before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants