cigarettes cigars lighters fit in helmet cosmetic

[hislittlecuzingames]

About the pull request

Allows smoking rp items to fit in helmet cosmetic slots instead of taking up "valuable" slots.

Explain why it's good for the game

If you fill up your slots with gear, you often cannot fit smoking items like cigarettes and lighters. This allows players to RP more with their ability to take RP items without sacrificing gameplay items.

please verify...
I thought you'd use pipe equals to add bitflags in dm ie
my-bitflag |= MYNEWVALUE
This wouldn't compile though...

I saw ampersand equals removes items not on the right side of equals.
So I used regular equals and it seems to fit into backpacks and webbing no problem.

Testing Photographs and Procedure

I tested by spawning using "create humans" and spawning USCM and their class.
I verified the items fit in each of the basic helmets and also put in "game items" like bandages and an injector to assure they took the cosmetic slots, not the "item" slots.

I also put the cigarettes into the 5 slot webbing and backpacks.

Screenshots & Videos

Changelog

🆑
qol: Can roleplay easier with cigarettes, cigars, lighters counting as cosmetic for helmet storage purposes.
/:cl:

[Drulikar]

I thought you'd use pipe equals to add bitflags in dm ie
my-bitflag |= MYNEWVALUE
This wouldn't compile though...

The error you likely got was that you can't assign a non-constant value in a definition.

Doing whatever |= thing means take whatever already exists in whatever and bitwise or that with thing. Since the existing value can be anything, thats not a constant value; and thus cannot be in a definition.

Code that has to execute cannot be in a definition.

With 515 the :: operator could do something similar though: e.g. flags_obj = parent_type::flags_obj|OBJ_IS_HELMET_GARB

But in this case the flags_object for all of these items, including /obj/item/clothing/mask/cigarette are already 0 so there is nothing to inherit for that flag currently.

[hislittlecuzingames]

Thanks for the code snippet.

I made the adjustment to the better code convention, removed cigar boxes and added matchboxes to be cosmetic slots in helmets.
I verified they (cigarette pack, lighter) fit in the com tech helmet.

re-requesting review.

[Drulikar]

Pr title and description currently still mentions cigars but code does nothing regarding cigars.

[hislittlecuzingames]

Pr title and description currently still mentions cigars but code does nothing regarding cigars.

the cigars are under the cigarettes as you mentioned. They're in the "flame tool" file for some reason.
~snip image

If you want me to test the cigar, I don't know where they are but if you tell me, I can produce screenshots of verified testing.

nevermind I can't read.

added appropriate support in "added cigar and weed support" commit.