Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Healer drone Overheal exploit #6847

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

Diegoflores31
Copy link
Contributor

@Diegoflores31 Diegoflores31 commented Aug 1, 2024

About the pull request

Fixes Healer drone being able to give you "overhealing". by adding a 1 second cooldown to their healing and making the healing process faster.

You can still get a little over heal after this PR but is not as bad now.

Explain why it's good for the game

The overhealing was insane . healer drone should not be able to preemptively heal you so you can keep healing mid-combat.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Healer drone apply salve now has a 1 second cooldown.
balance: Salve wound now heals slightly quicker.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Aug 1, 2024
@GrrrKitten
Copy link
Contributor

Metafriends weeping

@ihatethisengine
Copy link
Contributor

ihatethisengine commented Aug 2, 2024

You kinda need to elaborate what exactly is exploit here. That healing over time heals over time? That you can transfer more HP than they have so they will keep healing even after hitting max hp? That you can stack several healing over time so they will heal quite fast? That you can fight while still healing?

Anyway, you basically can do literally the same with the fruits. You should probably change the way healing over time works, maybe instead of stacking it should just kinda prolong the effect of healing. This way healing mid-combat will not be that strong.

Or maybe make hitting full HP remove the healing over time effect.

Also 1 second CD is pretty long, make it at least 0.5 IMO.

tl;dr you should just fix the thing you deem exploitable instead of making the caste less convenient to play, because with this PR you punish players who didn't mean to exploit.

@Diegoflores31
Copy link
Contributor Author

You kinda need to elaborate what exactly is exploit here. That healing over time heals over time? That you can transfer more HP than they have so they will keep healing even after hitting max hp? That you can stack several healing over time so they will heal quite fast? That you can fight while still healing?

Anyway, you basically can do literally the same with the fruits. You should probably change the way healing over time works, maybe instead of stacking it should just kinda prolong the effect of healing. This way healing mid-combat will not be that strong.

Or maybe make hitting full HP remove the healing over time effect.

Also 1 second CD is pretty long, make it at least 0.5 IMO.

tl;dr you should just fix the thing you deem exploitable instead of making the caste less convenient to play, because with this PR you punish players who didn't mean to exploit

1.- you can stack healing on a xeno that can go beyond their maximun health . so for example if a drone uses all its stacks on a lurker when a lurker is almost full . the lurker will keep healing , basically he can go out in combat and receive insane amounts of damage .
example: you heal 400hp lurker with your 5-6 stacks of health . lurker goes into battle and somehow can tank up to 800 HP because the still has about 400 HP in healing for the next 8 seconds . usually with other healings like queen is not a problem because it cannot be stacked and heals slow but with drone it is a problem because he can stack it.

2.- while fruits Can be "stacked" they cant be instantly eaten nor you can stack 5 fruits in less than 1 second , unless you have 5 xenos feeding you simultaneusly of course but that is a crazy hypothetical compared to a drone just pressing a heal multiple times.

3.- i have tested this and the healing is almost the same. I originally made it 0,5 but realized it made no difference unless it was 1 second.

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise feels fine

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Aug 3, 2024
@Drulikar Drulikar added this pull request to the merge queue Aug 3, 2024
Merged via the queue into cmss13-devs:master with commit 09a6055 Aug 3, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants