Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "in_hands" and "onmob" icon sprites for objects, book import from PVE (thanks Amory), small changes and fixes #6951

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
7a7c03b
R.T.S.1
LC4492 Apr 10, 2024
184b45b
Merge branch 'master' of https://github.com/LC4492/CM-Space-Station-13
LC4492 May 23, 2024
ae3caa1
Merge branch 'cmss13-devs:master' into master
LC4492 Jun 13, 2024
066478e
Merge branch 'cmss13-devs:master' into master
LC4492 Jun 27, 2024
5ddbf4a
Merge branch 'cmss13-devs:master' into master
LC4492 Jul 12, 2024
31e22ad
Merge branch 'cmss13-devs:master' into master
LC4492 Jul 20, 2024
82201a0
Merge branch 'cmss13-devs:master' into master
LC4492 Jul 29, 2024
43797f5
Merge branch 'cmss13-devs:master' into master
LC4492 Aug 6, 2024
6c53f32
Merge branch 'cmss13-devs:master' into master
LC4492 Aug 14, 2024
a66f65f
First Sprite Pack, small changes
LC4492 Aug 14, 2024
04bd561
Fix 1
LC4492 Aug 15, 2024
93f592a
Fix 2
LC4492 Aug 15, 2024
f2559eb
Merge branch 'master' into New-in_hand-sprites
LC4492 Aug 15, 2024
57194f6
Fix 3
LC4492 Aug 15, 2024
aca99c5
fix
Blundir Aug 16, 2024
3a7387d
Merge branch 'cmss13-devs:master' into master
LC4492 Sep 1, 2024
3ec8d4d
Merge branch 'cmss13-devs:master' into master
LC4492 Sep 7, 2024
3d5ff0c
Merge branch 'master' into New-in_hand-sprites
LC4492 Sep 8, 2024
6636854
Merge branch 'New-in_hand-sprites' of https://github.com/LC4492/CM-Sp…
LC4492 Sep 8, 2024
ad2a320
In_hand revolution, Part One
LC4492 Oct 19, 2024
53a75b5
Merge branch 'master' into New-in_hand-sprites
LC4492 Oct 19, 2024
5c6c12f
fix 1=
LC4492 Oct 19, 2024
a9c6df1
fix 2
LC4492 Oct 19, 2024
9611fbe
Fix 3
LC4492 Oct 19, 2024
f56d431
Fix 4
LC4492 Oct 19, 2024
134a7dc
Fix 5
LC4492 Oct 19, 2024
b82dc41
Fix 6
LC4492 Oct 19, 2024
6d12062
Snacks, matches (WIP) and fixes
LC4492 Oct 28, 2024
4d2c9f8
Fix 2
LC4492 Oct 28, 2024
bcbd773
Fix 2
LC4492 Oct 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/game/objects/items.dm
Original file line number Diff line number Diff line change
Expand Up @@ -914,8 +914,8 @@ cases. Override_icon_state should be a list.*/

SEND_SIGNAL(src, COMSIG_ITEM_ZOOM, user)
var/zoom_device = zoomdevicename ? "\improper [zoomdevicename] of [src]" : "\improper [src]"
user.visible_message(SPAN_NOTICE("[user] peers through \the [zoom_device]."),
SPAN_NOTICE("You peer through \the [zoom_device]."))
user.visible_message(SPAN_NOTICE("[user] peers through [zoom_device]."),
SPAN_NOTICE("You peer through [zoom_device]."))
zoom = !zoom

/obj/item/proc/get_icon_state(mob/user_mob, slot)
Expand Down
2 changes: 2 additions & 0 deletions code/game/objects/items/bodybag.dm
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
desc = "A folded bag designed for the storage and transportation of cadavers."
icon = 'icons/obj/bodybag.dmi'
icon_state = "bodybag_folded"
item_state = "bodybag"
w_class = SIZE_SMALL
var/unfolded_path = /obj/structure/closet/bodybag

Expand Down Expand Up @@ -33,6 +34,7 @@
desc = "A folded, reusable bag designed to prevent additional damage to an occupant."
icon = 'icons/obj/cryobag.dmi'
icon_state = "bodybag_folded"
item_state = "cryobag"
unfolded_path = /obj/structure/closet/bodybag/cryobag
matter = list("plastic" = 7500)
var/used = 0
Expand Down
4 changes: 4 additions & 0 deletions code/game/objects/items/books/book.dm
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
name = "book"
icon = 'icons/obj/items/books.dmi'
icon_state ="book"
item_icons = list(
WEAR_L_HAND = 'icons/mob/humans/onmob/items_lefthand_1.dmi',
WEAR_R_HAND = 'icons/mob/humans/onmob/items_righthand_1.dmi'
)
throw_speed = SPEED_FAST
throw_range = 5
/// upped to three because books are, y'know, pretty big. (and you could hide them inside eachother recursively forever)
Expand Down
48 changes: 32 additions & 16 deletions code/game/objects/items/books/manuals.dm
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@

/obj/item/book/manual/engineering_construction
name = "Station Repairs and Construction"
icon_state ="bookEngineering"
icon_state = "book_engineering"
item_state = "book_engineering"
author = "Engineering Encyclopedia"
title = "Station Repairs and Construction"

Expand All @@ -31,7 +32,8 @@

/obj/item/book/manual/engineering_hacking
name = "Hacking"
icon_state ="bookHacking"
icon_state = "book_hacking"
item_state = "book_hacking"
author = "Engineering Encyclopedia"
title = "Hacking"

Expand All @@ -51,7 +53,8 @@

/obj/item/book/manual/ripley_build_and_repair
name = "APLU \"Ripley\" Construction and Operation Manual"
icon_state ="book"
icon_state = "book_dark"
item_state = "book_dark"
author = "Randall Varn, Einstein Engines Senior Mechanic"
title = "APLU \"Ripley\" Construction and Operation Manual"

Expand Down Expand Up @@ -128,7 +131,8 @@

/obj/item/book/manual/research_and_development
name = "Research and Development 101"
icon_state = "rdbook"
icon_state = "book_white"
item_state = "book_white"
author = "Dr. L. Ight"
title = "Research and Development 101"

Expand All @@ -149,7 +153,8 @@
/obj/item/book/manual/security_space_law
name = "Standard Operating Procedure"
desc = "A set of USCM guidelines for keeping law and order on their vessels."
icon_state = "bookSpaceLaw"
icon_state = "book_sop"
item_state = "book_sop"
author = "USCM High Command"
title = "Standard Operating Procedure"

Expand All @@ -170,7 +175,8 @@
/obj/item/book/manual/marine_law
name = "Marine Law"
desc = "A set of guidelines for keeping law and order on military vessels."
icon_state = "bookSpaceLaw"
icon_state = "book_law"
item_state = "book_law"
author = "USCM High Command"
title = "Marine Law"

Expand All @@ -191,7 +197,8 @@
/obj/item/book/manual/surgery
name = "Surgical Reference Manual"
desc = "A quick reference manual for surgical procedures."
icon_state = "bookMedical"
icon_state = "book_medical"
item_state = "book_medical"
author = "Weyland-Yutani Medicine Department"
title = "Surgical Reference Manual"

Expand All @@ -212,7 +219,8 @@
/obj/item/book/manual/medical_diagnostics_manual
name = "WY Medical Diagnostics Manual"
desc = "First, do no harm. A detailed medical practitioner's guide."
icon_state = "bookMedical"
icon_state = "book_medical"
item_state = "book_medical"
author = "Weyland-Yutani Medicine Department"
title = "WY Medical Diagnostics Manual"

Expand Down Expand Up @@ -257,7 +265,8 @@

/obj/item/book/manual/engineering_guide
name = "Engineering Textbook"
icon_state ="bookEngineering2"
icon_state = "book_engineering"
item_state = "book_engineering"
author = "Engineering Encyclopedia"
title = "Engineering Textbook"

Expand All @@ -276,7 +285,8 @@

/obj/item/book/manual/chef_recipes
name = "Chef Recipes"
icon_state = "cooked_book"
icon_state = "book_green"
item_state = "book_green"
author = "Victoria Ponsonby"
title = "Chef Recipes"

Expand Down Expand Up @@ -335,7 +345,8 @@

/obj/item/book/manual/barman_recipes
name = "Barman Recipes"
icon_state = "barbook"
icon_state = "book_red"
item_state = "book_red"
author = "Sir John Rose"
title = "Barman Recipes"

Expand Down Expand Up @@ -434,7 +445,8 @@

/obj/item/book/manual/nuclear
name = "Fission Mailed: Nuclear Sabotage 101"
icon_state ="bookNuclear"
icon_state = "book_particle"
item_state = "book_particle"
author = "The Colonial Liberation Front"
title = "Fission Mailed: Nuclear Sabotage 101"

Expand Down Expand Up @@ -486,7 +498,8 @@

/obj/item/book/manual/atmospipes
name = "Pipes and You: Getting To Know Your Scary Tools"
icon_state = "pipingbook"
icon_state = "book_piping"
item_state = "book_piping"
author = "Maria Crash, Senior Atmospherics Technician"
title = "Pipes and You: Getting To Know Your Scary Tools"
dat = {"<html>
Expand Down Expand Up @@ -594,7 +607,8 @@

/obj/item/book/manual/evaguide
name = "EVA Gear and You: Not Spending All Day Inside"
icon_state = "evabook"
icon_state = "book_blue"
item_state = "book_blue"
author = "Maria Crash, Senior Atmospherics Technician"
title = "EVA Gear and You: Not Spending All Day Inside"
dat = {"<html>
Expand Down Expand Up @@ -666,7 +680,8 @@

/obj/item/book/manual/hydroponics_beekeeping
name = "The Ins and Outs of Apiculture - A Precise Art"
icon_state ="bookHydroponicsBees"
icon_state = "book_green"
item_state = "book_green"
author = "Beekeeper Dave"
title = "The Ins and Outs of Apiculture - A Precise Art"
dat = {"<html>
Expand Down Expand Up @@ -698,7 +713,8 @@

/obj/item/book/manual/orbital_cannon_manual
name = "USCM Orbital Bombardment System Manual"
icon_state = "bookEngineering"
icon_state = "book_engineering"
item_state = "book_engineering"
author = "USCM R&D"
title = "USCM Orbital Bombardment System Manual"

Expand Down
23 changes: 23 additions & 0 deletions code/game/objects/items/devices/binoculars.dm
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
desc = "A military-issued pair of binoculars."
icon = 'icons/obj/items/binoculars.dmi'
icon_state = "binoculars"
item_state = "binoculars"
pickup_sound = 'sound/handling/wirecutter_pickup.ogg'
drop_sound = 'sound/handling/wirecutter_drop.ogg'
flags_atom = FPRINT|CONDUCT
Expand All @@ -14,6 +15,7 @@
throw_speed = SPEED_VERY_FAST
/// If FALSE won't change icon_state to a camo marine bino.
var/uses_camo = TRUE
var/raised = FALSE


//matter = list("metal" = 50,"glass" = 50)
Expand All @@ -30,8 +32,29 @@
if(SEND_SIGNAL(user, COMSIG_BINOCULAR_ATTACK_SELF, src))
return

if(raised)
set_raised(FALSE, user)
else
set_raised(TRUE, user)

zoom(user, 11, 12)

/obj/item/device/binoculars/proc/set_raised(to_raise, mob/living/carbon/human/user)
if(!istype(user))
return

if(!to_raise)
raised = FALSE
item_state = icon_state
else if(!COOLDOWN_FINISHED(user, zoom_cooldown))
item_state = icon_state
else
raised = TRUE
item_state = item_state + "_eyes"

user.update_inv_r_hand()
user.update_inv_l_hand()

/obj/item/device/binoculars/dropped(/obj/item/item, mob/user)
. = ..()
on_unset_interaction(user)
Expand Down
7 changes: 6 additions & 1 deletion code/game/objects/items/devices/flashlight.dm
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
desc = "A hand-held emergency light."
icon = 'icons/obj/items/lighting.dmi'
icon_state = "flashlight"
item_state = "flashlight"
item_state = ""
w_class = SIZE_SMALL
flags_atom = FPRINT|CONDUCT
flags_equip_slot = SLOT_WAIST
Expand Down Expand Up @@ -518,8 +518,13 @@
/obj/item/device/flashlight/lantern
name = "lantern"
icon_state = "lantern"
item_state = ""
desc = "A mining lantern."
light_range = 6 // luminosity when on
light_color = "#d69c46"

/obj/item/device/flashlight/lantern/on
on = TRUE

//Signal Flare
/obj/item/device/flashlight/flare/signal
Expand Down
4 changes: 4 additions & 0 deletions code/game/objects/items/explosives/explosive.dm
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@
var/use_dir = FALSE
var/angle = 360
var/has_blast_wave_dampener = FALSE; //Whether or not the casing can be toggle between different falloff_mode
item_icons = list(
WEAR_L_HAND = 'icons/mob/humans/onmob/items_lefthand_1.dmi',
WEAR_R_HAND = 'icons/mob/humans/onmob/items_righthand_1.dmi'
)

/obj/item/explosive/Initialize()
. = ..()
Expand Down
4 changes: 4 additions & 0 deletions code/game/objects/items/explosives/grenades/grenade.dm
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
icon = 'icons/obj/items/weapons/grenade.dmi'
icon_state = "grenade"
item_state = "grenade"
item_icons = list(
WEAR_L_HAND = 'icons/mob/humans/onmob/items_lefthand_1.dmi',
WEAR_R_HAND = 'icons/mob/humans/onmob/items_righthand_1.dmi'
)
throw_speed = SPEED_VERY_FAST
throw_range = 7
flags_atom = FPRINT|CONDUCT
Expand Down
1 change: 1 addition & 0 deletions code/game/objects/items/explosives/plastic.dm
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@
name = "breaching charge"
desc = "An explosive device used to break into areas while protecting the user from the blast as well as deploying deadly shrapnel on the other side."
icon_state = "satchel-charge"
item_state = "satchel-charge"
overlay_image = "satchel-active"
w_class = SIZE_SMALL
angle = 55
Expand Down
6 changes: 6 additions & 0 deletions code/game/objects/items/frames/table_rack.dm
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
desc = "A kit for a table, including a large, flat metal surface and four legs. This kit has side panels. Some assembly required."
icon = 'icons/obj/items/items.dmi'
icon_state = "reinf_tableparts"
item_state = "reinf_tableparts"
matter = list("metal" = 15000) //A reinforced table. Two sheets of metal and four rods
table_type = /obj/structure/surface/table/reinforced

Expand All @@ -102,6 +103,7 @@
name = "wooden table parts"
desc = "A kit for a table, including a large, flat wooden surface and four legs. Some assembly required."
icon_state = "wood_tableparts"
item_state = "wood_tableparts"
flags_atom = FPRINT
matter = null
table_type = /obj/structure/surface/table/woodentable
Expand All @@ -127,12 +129,14 @@
name = "poor wooden table parts"
desc = "A kit for a poorly crafted table, including a large, flat wooden surface and four legs. Some assembly required."
icon_state = "pwood_tableparts"
item_state = "pwood_tableparts"
table_type = /obj/structure/surface/table/woodentable/poor

/obj/item/frame/table/wood/fancy
name = "fancy wooden table parts"
desc = "A kit for a finely crafted mahogany table, including a large, flat wooden surface and four legs. Some assembly required."
icon_state = "fwood_tableparts"
item_state = "fwood_tableparts"
table_type = /obj/structure/surface/table/woodentable/fancy

/*
Expand All @@ -143,6 +147,7 @@
name = "gamble table parts"
desc = "A kit for a table, including a large, flat wooden and carpet surface and four legs. Some assembly required."
icon_state = "gamble_tableparts"
item_state = "gamble_tableparts"
flags_atom = null
matter = null
table_type = /obj/structure/surface/table/gamblingtable
Expand All @@ -169,6 +174,7 @@
/obj/item/frame/table/almayer
name = "gray table parts"
icon_state = "table_parts"
item_state = "tableparts"
table_type = /obj/structure/surface/table/almayer


Expand Down
3 changes: 3 additions & 0 deletions code/game/objects/items/reagent_containers/dropper.dm
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
if (src.reagents.total_volume<=0)
filled = 0
icon_state = "dropper[filled]"
item_state = "dropper0"
return

for(var/mob/O in viewers(GLOB.world_view_size, user))
Expand All @@ -86,6 +87,7 @@
if (src.reagents.total_volume<=0)
filled = 0
icon_state = "dropper[filled]"
item_state = "dropper0"

else

Expand All @@ -107,6 +109,7 @@

filled = 1
icon_state = "dropper[filled]"
item_state = "dropper1"

return

Expand Down
Loading
Loading