-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Kutjevo Refinery Rework. #6971
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apping-kutjevo-1
…apping-kutjevo-1
github-actions
bot
added
Sprites
Remove the soul from the game.
Mapping
did you remember to save in tgm format?
labels
Aug 18, 2024
cm13-github
added
the
Merge Conflict
PR can't be merged because it touched too much code
label
Oct 5, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…apping-kutjevo-1
cm13-github
removed
the
Merge Conflict
PR can't be merged because it touched too much code
label
Oct 19, 2024
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 27, 2024
# About the pull request I am working on Kutjevo Rework: #6971 I have plans of adding large quantities of boulders to area called "Stony Fields". # Explain why it's good for the game Some person was sadistic, because for some reason, you can melt wide boulders 1x2, but you are unable to melt 1x1 boulders or large 2x2 boulders, this PR allow you to melt this rocks, if you are not convinced, there is photo of one bullshit spot on trijent dam below. And to be serious, it just don't make sense you can melt wide boulders, but other variants are unmeltable, if its made from same rock, make them all equal, and not some wierd "this one can be melted but other do not" type of logic. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> ![image](https://github.com/user-attachments/assets/9cd6cbb1-7484-413b-9e7d-046814bcc2f9) </details> # Changelog :cl: code: Removed code for some boudlers, removed code makes boulders meltable and destructable by large explosions. /:cl:
cm13-github
added
the
Merge Conflict
PR can't be merged because it touched too much code
label
Oct 29, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 9, 2024
**!!!DISCLAIMER!!! I am very bad at spriting and i am not joking.** **_I recommend to put this PR in Testmerge, so i can find issues caused by swapping paths and find oversights with sprites._** <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> # About the pull request I am working on rework of Kutjevo #6971 Fixes: #7049 Because i plan to add elevation by using large quantities of platform edges, i tough it will be too annoying for players, who are keep dying, like xenos and marines because edge stopped them for 1-2 seconds. **Edit: Its 70% done, i just lack sprites. _(made only one platform sprite set for demonstration in videos below)_** Edit(07.09): I was forced to change paths of platforms so they can play different sounds depending on what they are made of. Edit(15.09): Finally done sprites, now time to wait. Edit(21.09): thanks to **Doubleumc | Casey Walton** and **cuberound** for having time explain me some code related terms, thanks you both for that. Edit(15.10): Added Stair variant of Platform with own sprites and broken states. # Explain why it's good for the game Allow game to be more dynamic by adding little more "terrain destruction" that will benefit gameplay and mappers who like to keep Map elevation but they are worried that platform edges will make experience negative. (people complain a lot) # Testing Photographs and Procedure <!-- Include any screenshots/videos/debugging steps of the modified code functioning successfully, ideally including edge cases. --> <!-- !! If you are modifying sprites, you **must** include one or more in-game screenshots or videos of the new sprites. !! --> <details> <summary>Click HERE to see Videos</summary> Platforms **before** destruction: ![New1](https://github.com/user-attachments/assets/fd8d2149-eced-43f6-9207-d535833b0e7d) Platforms **after** destruction: ![New2](https://github.com/user-attachments/assets/bba20591-8df3-46fa-b72b-67b1f9bf728a) How it work and sound when xeno break them: https://github.com/user-attachments/assets/de9e8c9e-ffaf-4544-beab-a58640b857fa How it will work for Explosions: https://github.com/user-attachments/assets/cbc5e4bb-1603-42bf-aa02-c3e875f86292 </details> # Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly label your changes in the changelog. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> <!-- If you add a name after the ':cl', that name will be used in the changelog. You must add your CKEY after the CL if your GitHub name doesn't match. Maintainers freely reserve the right to remove and add tags should they deem it appropriate. --> :cl: Venuska1117 code: Added ability to Destroy Platform Edges by xenos on "Disarm" intent, now depending on xenos "size" they can break Platform Edges quicker or Slower, Now Explosives have chance to destroy Platform Edges by depending on how strong explosion is. imageadd: Added Sprites for Broken Platforms Edges. soundadd: Added Sound for Breaking "Stone" Edges. /:cl: <!-- Both :cl:'s are required for the changelog to work! --> --------- Co-authored-by: Drulikar <[email protected]>
I will re-open this PR after i do any work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mapping
did you remember to save in tgm format?
Merge Conflict
PR can't be merged because it touched too much code
Sprites
Remove the soul from the game.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will improve description later when map will be ready.
About the pull request
Change Kutjevo Refinery base concept by adding more terrain destruction, map patterns and expands areas of contact.
Requires:
Explain why it's good for the game
Makes Game Experience better, add new terrain, more structures, enhance visuals, all of this will improve gameplay and experience.
List of changes:
Testing Photographs and Procedure
high quality image from map maker: (open in browser or download for higher quality)
Click THIS to see image
Last Image Updated: 22.08 at 12:55 (GTM +2)
Changelog
🆑
maptweak: Rework Kutjevo Refinery
/:cl: