Adds a webhook for sending the top 10 overtiming procs to discord #7139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm13-github
added a commit
that referenced
this pull request
Sep 9, 2024
harryob
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
As the title says. Will list out the 10 most overtiming procs. Happens at the end of a round.
Some important documentation here: Overtime is the time that a proc runs over tick for. Any amount of overtime is typically bad and, if high enough, needs to have a
CHECK_TICKcall within itself or it needs to run on a subsystem.High amounts of overtime directly links to any of the large lagspikes you might see during gameplay. If you notice that everyone freezes for a few seconds during gameplay, that's because a proc suddenly spiked in overtime.
Incremental amounts of overtime can lead to gameplay stutters as well. It's impossible to completely eliminate overtime but it provides a good performance target for which procs have the most dangerous serverside cost, depending on how much average overtime they typically have.
Explain why it's good for the game
Might get more visibility on procs that actually cause performance issues. Since profiler information is probably not easily available to players and contributors, this might provide an optimization goal for them, and a clear idea of what might be causing serverside lagspikes during gameplay.
Testing Photographs and Procedure
Changelog
🆑
add: Added a webhook to send the top 10 most overtiming procs to a discord webhook on server shutdown.
/:cl: