-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds and expands on the descriptions of tank hardpoints & magazins #7398
Merged
harryob
merged 19 commits into
cmss13-devs:master
from
TheManWithNoHands:tank-weapon-discription
Oct 28, 2024
Merged
Adds and expands on the descriptions of tank hardpoints & magazins #7398
harryob
merged 19 commits into
cmss13-devs:master
from
TheManWithNoHands:tank-weapon-discription
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryob
requested changes
Oct 27, 2024
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
German grammar rules be rooted deep |
harryob
requested changes
Oct 28, 2024
code/modules/vehicles/hardpoints/hardpoint_ammo/minigun_ammo.dm
Outdated
Show resolved
Hide resolved
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
Co-authored-by: harryob <[email protected]>
…o.dm Co-authored-by: harryob <[email protected]>
harryob
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Explain why it's good for the game
Currently you dont really know what the gun does you select for the tank. Wich is kinda shit.
Your lucky, and finally get to play tank crew for the first time... and you have no clue what any of the guns do. This should help with that.
Being that, you know, you can now read what the gun does your commiting to.
Also, a lot of descriptions where 100% placeholders of the items. The tank is really in dire need of some updates.
So i gave most of them description with some more flavor to them then just "Its a tank primary".
Also, im kinda unsure what type of changelog this applys to.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑TheManWithNoHands
add: Added vendor description to: AC3-E autocanon, LTAA-AP Minigun, DRG-N Flamer, LTB canon, LZR-N Flamer, TOW launcher, M56cupola, and M92T Grenade Launcher.
add: Expanded the description of: LTAA-AP Minigun, TOW launcher, M56cupola, M92T Grenade Launcher and the magazins of the AC3-E autocanon, LTAA-AP Minigun, DRG-N Flamer, LZR-N Flamer, and M92T Grenade Launcher. As well as for the snowplow hardpoint and heavy and ligth treads.
/:cl: