Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds and expands on the descriptions of tank hardpoints & magazins #7398

Merged
merged 19 commits into from
Oct 28, 2024

Conversation

TheManWithNoHands
Copy link
Contributor

@TheManWithNoHands TheManWithNoHands commented Oct 27, 2024

About the pull request

  • Adds descriptions in the vehicle vendor to tank hardpoint weapon options. Giving a small description to how the guns work.
  • Gives the magazins and hardpoints item descriptions a more flavorfull description, being that most where literally placeholders.

Explain why it's good for the game

Currently you dont really know what the gun does you select for the tank. Wich is kinda shit.
Your lucky, and finally get to play tank crew for the first time... and you have no clue what any of the guns do. This should help with that.
Being that, you know, you can now read what the gun does your commiting to.

Also, a lot of descriptions where 100% placeholders of the items. The tank is really in dire need of some updates.
So i gave most of them description with some more flavor to them then just "Its a tank primary".

Also, im kinda unsure what type of changelog this applys to.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑TheManWithNoHands
add: Added vendor description to: AC3-E autocanon, LTAA-AP Minigun, DRG-N Flamer, LTB canon, LZR-N Flamer, TOW launcher, M56cupola, and M92T Grenade Launcher.
add: Expanded the description of: LTAA-AP Minigun, TOW launcher, M56cupola, M92T Grenade Launcher and the magazins of the AC3-E autocanon, LTAA-AP Minigun, DRG-N Flamer, LZR-N Flamer, and M92T Grenade Launcher. As well as for the snowplow hardpoint and heavy and ligth treads.
/:cl:

@cmss13-ci cmss13-ci bot added the Feature Feature coder badge label Oct 27, 2024
@harryob harryob marked this pull request as draft October 27, 2024 21:57
@TheManWithNoHands
Copy link
Contributor Author

German grammar rules be rooted deep

@TheManWithNoHands TheManWithNoHands marked this pull request as ready for review October 27, 2024 23:39
code/modules/vehicles/hardpoints/armor/snowplow.dm Outdated Show resolved Hide resolved
code/modules/vehicles/hardpoints/hardpoint_ammo/gl_ammo.dm Outdated Show resolved Hide resolved
code/modules/vehicles/hardpoints/secondary/cupola.dm Outdated Show resolved Hide resolved
code/modules/vehicles/hardpoints/wheels/treads.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft October 28, 2024 07:28
@harryob harryob marked this pull request as ready for review October 28, 2024 16:08
@harryob harryob added this pull request to the merge queue Oct 28, 2024
Merged via the queue into cmss13-devs:master with commit a03c4d8 Oct 28, 2024
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Oct 28, 2024
@TheManWithNoHands TheManWithNoHands deleted the tank-weapon-discription branch October 28, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants