Adds support for additional containers (sidecars) #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need latest changes from this module
Fixes default target group names to be compatible with naming scheme .
* String any (#3) * Add deployment_controller (#1) * Add deployment_controller Add support for setting deployment_controller of service * Change type string -> any * Change type string -> any * use test branch ref * Formatting * Adds support for additional load balancer feature & using force_new_deployment flag of ECS. * Adds the ability to configure additional containers (sidecars) --------- Co-authored-by: Jared Darling <[email protected]>
* String any (#3) * Add deployment_controller (#1) * Add deployment_controller Add support for setting deployment_controller of service * Change type string -> any * Change type string -> any * use test branch ref * Formatting * Adds support for additional load balancer feature & using force_new_deployment flag of ECS. * Adds the ability to configure additional containers (sidecars) * Formatting --------- Co-authored-by: Jared Darling <[email protected]>
* String any (#3) * Add deployment_controller (#1) Add support for setting deployment_controller of service * Change type string -> any * use test branch ref * Adds support for additional load balancer feature & using force_new_deployment flag of ECS. * Adds the ability to configure additional containers (sidecars) * Update to latest module versions --------- Co-authored-by: Jared Darling <[email protected]>
|
I have a fix for the tests that I'll submit today. |
* String any (#3) * Add deployment_controller (#1) * Add deployment_controller Add support for setting deployment_controller of service * Change type string -> any * Change type string -> any * use test branch ref * Formatting * Adds support for additional load balancer feature & using force_new_deployment flag of ECS. * Adds the ability to configure additional containers (sidecars) * Formatting * Update to latest module versions * Sets default deployment_controller to fix test --------- Co-authored-by: Jared Darling <[email protected]>
* String any (#3) * Add deployment_controller (#1) * Add deployment_controller Add support for setting deployment_controller of service * Change type string -> any * Change type string -> any * use test branch ref * Formatting * Adds support for additional load balancer feature & using force_new_deployment flag of ECS. * Adds the ability to configure additional containers (sidecars) * Formatting * Update to latest module versions * Sets default deployment_controller to fix test * Formatting --------- Co-authored-by: Jared Darling <[email protected]>
|
@jnonino Tests fixed. Ready for final review. |
JaredDarling
commented
Oct 14, 2023
| interactive = var.interactive | ||
| pseudo_terminal = var.pseudo_terminal | ||
| docker_security_options = var.docker_security_options | ||
| additional_containers = var.additional_containers |
There was a problem hiding this comment.
additional_containers is the new variable. The rest are modified due to re-ordering (sorted).
JaredDarling
commented
Oct 14, 2023
| @@ -115,6 +117,7 @@ module "ecs-fargate-service" { | |||
|
|
|||
| # Application Load Balancer | |||
| custom_lb_arn = var.custom_lb_arn | |||
| additional_lbs = var.additional_lbs | |||
There was a problem hiding this comment.
additional_lbs is also a new feature.
JaredDarling
commented
Oct 14, 2023
| enable_ecs_managed_tags = var.enable_ecs_managed_tags | ||
| enable_execute_command = var.enable_execute_command | ||
| force_new_deployment = var.force_new_deployment |
There was a problem hiding this comment.
New feature to keep service always up to date.
jnonino
approved these changes
Oct 18, 2023
This was referenced Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.