Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): validate that url must be a valid url with http or https #19

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

vvatelot
Copy link
Member

@vvatelot vvatelot commented Dec 8, 2023

No description provided.

Copy link

github-actions bot commented Dec 8, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
bases/ecoindex/cli
   __init__.py00100% 
   app.py995247%125–128, 130, 145–146, 181–182, 184, 192, 201, 203–204, 206–208, 224, 226–228, 230–231, 234, 236–239, 241, 243–244, 249, 253–254, 256, 258, 261, 263–265, 267–268, 271–273, 281, 285, 317, 319, 327, 331, 335
   arguments_handler.py611083%38–41, 43–44, 50–52, 54
   console_output.py10730%6, 8–12, 14
   crawl.py15660%20–24, 27
   helper.py10640%15, 22–25, 27
   report.py634626%29, 31–32, 34–35, 37–41, 44, 49, 54, 59–60, 63–66, 74–77, 80, 86, 92–94, 97, 99, 103, 105–107, 109, 120–121, 124–125, 130, 136, 180, 183–184, 186–187
components/ecoindex/compute
   __init__.py20100% 
   ecoindex.py28196%48
components/ecoindex/data
   __init__.py120100% 
   colors.py70100% 
   grades.py70100% 
   medians.py30100% 
   quantiles.py30100% 
   targets.py30100% 
components/ecoindex/exceptions
   __init__.py00100% 
   scraper.py8362%7–9
components/ecoindex/models
   __init__.py60100% 
   compute.py65592%111, 113, 116, 118, 134
   enums.py26196%9
   response_examples.py50100% 
   scraper.py100100% 
   sort.py50100% 
components/ecoindex/scraper
   __init__.py20100% 
   scrap.py683548%45, 48–49, 51, 60–62, 67–70, 76–79, 82–83, 85–86, 88, 90, 97–100, 107–108, 110–111, 120–121, 123, 126–127, 129
components/ecoindex/utils
   __init__.py20100% 
   files.py451957%23–25, 29, 34, 36–37, 39–41, 46–47, 60–61, 63–64, 80–82
   screenshots.py12741%8–10, 12, 16, 22–23
test/bases/ecoindex/cli
   __init__.py00100% 
   test_app.py520100% 
   test_arguments_handler.py340100% 
test/components/ecoindex/compute
   __init__.py00100% 
   test_ecoindex.py380100% 
   test_models.py75988%122–130
test/components/ecoindex/scraper
   __init__.py00100% 
   test_scraper.py320100% 
TOTAL80820774% 

@vvatelot vvatelot merged commit 9141d1c into main Dec 8, 2023
5 checks passed
@vvatelot vvatelot deleted the fix/api/http-url-new-analyzis branch December 8, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant