[ConvexBase] Fix neighbor copy in copy constructor. #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the pointers in neighbors were not pointing to the data stored in nneighbors_ but to other.nneighbors_. If other.nneighbors_ is destroyed then the neighbors point to deleted data. This commit fixes that.
jcarpent
force-pushed
the
topic/hppfcl3x/fix_convex_neighbor_copy
branch
from
a18481e to
b2f759a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the pointers in
neighborswere not pointing to the data stored innneighbors_but toother.nneighbors_.If
other.nneighbors_is destroyed then the neighbors point to deleted data. This PR fixes that.