Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide qhullcpp symbol #527

Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from
Draft

Hide qhullcpp symbol #527

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa14857
cmake: don't expose qhullcpp symbols
jorisv Dec 11, 2023
7afca56
cmake: don't add --exclude-libs on Mac
jorisv Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,12 @@ if(HPP_FCL_HAS_QHULL)
target_compile_definitions(${LIBRARY_NAME} PRIVATE -DHPP_FCL_HAS_QHULL)
if (HPP_FCL_USE_SYSTEM_QHULL)
target_link_libraries(${LIBRARY_NAME} PRIVATE Qhull::qhull_r Qhull::qhullcpp)
# On Linux, don't export libqhullcpp symbols to avoid conflict with other libraries
# that depend on QHull
if(UNIX AND NOT APPLE)
set_target_properties(
${LIBRARY_NAME} PROPERTIES LINK_FLAGS "-Wl,--exclude-libs,libqhullcpp")
endif()
else()
target_include_directories(${LIBRARY_NAME} SYSTEM PRIVATE
${Qhull_r_INCLUDE_DIR} ${Qhullcpp_PREFIX})
Expand Down
Loading