Merge #131378

131378: storage: re-enable multi-level compactions r=nicktrav a=jbowens The issue of excessively large multi-level compactions was resolved. See cockroachdb/pebble#3120. Epic: none Release note (performance improvement): Enables multi-level compactions which moderately reduce write amplification within the storage engine. Co-authored-by: Jackson Owens <[email protected]>
cockroachdb · Sep 25, 2024 · c2ff682 · c2ff682
2 parents e49c98b + 66be9b8
commit c2ff682
Showing 1 changed file with 0 additions and 6 deletions.
diff --git a/pkg/storage/pebble.go b/pkg/storage/pebble.go
@@ -1192,12 +1192,6 @@ func newPebble(ctx context.Context, cfg engineConfig) (p *Pebble, err error) {
 		// Pebble has better guards against this.
 		return cfg.sharedStorage != nil || !IngestAsFlushable.Get(&cfg.settings.SV)
 	}
-	// Multi-level compactions were discovered to cause excessively large
-	// compactions that can have adverse affects. We disable these types of
-	// compactions for now.
-	// See https://github.com/cockroachdb/pebble/issues/3120
-	// TODO(travers): Re-enable, once the issues are resolved.
-	cfg.opts.Experimental.MultiLevelCompactionHeuristic = pebble.NoMultiLevel{}
 	cfg.opts.Experimental.IngestSplit = func() bool {
 		return IngestSplitEnabled.Get(&cfg.settings.SV)
 	}