server: create api to trigger table metadata update job #130721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kyle-a-wong
force-pushed
the
trigger_update_job_api
branch
3 times, most recently
from
013a51c
to
20e46e0
Compare
kyle-a-wong
requested review from
xinhaoz,
dhartunian and
angles-n-daemons
and removed request for
a team
xinhaoz
reviewed
Sep 17, 2024
kyle-a-wong
force-pushed
the
trigger_update_job_api
branch
9 times, most recently
from
c6dc399
to
afcf872
Compare
kyle-a-wong
force-pushed
the
trigger_update_job_api
branch
3 times, most recently
from
c49c4d9
to
3479f41
Compare
xinhaoz
approved these changes
Sep 23, 2024
| @@ -4211,7 +4211,7 @@ func (s *statusServer) localUpdateTableMetadataCache() ( | |||
| select { | |||
| case s.updateTableMetadataJobSignal <- struct{}{}: | |||
| default: | |||
| return nil, status.Errorf(codes.Unavailable, "update table metadata cache job is not ready to start execution") | |||
| return nil, status.Errorf(codes.Aborted, "update table metadata cache job is not ready to start execution") | |||
There was a problem hiding this comment.
Just curious, why the switch to aborted here?
There was a problem hiding this comment.
I think that typically, the unavailable status should be used for when the service is temporarily unavailable, where as the aborted status should be used when an operation is aborted. To me this case falls under an latter.
adds a new API v2 endpoint, `POST /api/v2/table_metadata/updatejob`. This new API will trigger the table metadata update job to run and refresh the system.table_metadata table. This will only trigger the job if it isn't already running. If the `?onlyIfStale` query param is provided, the job won't be triggered unless deemed stale, determined by the following setting: `obs.tablemetadata.data_valid_duration` note that `onlyIfStale` with any value other then `false` will be treated as true. Resolves: cockroachdb#128897 Epic: CRDB-37558 Release note: None
kyle-a-wong
force-pushed
the
trigger_update_job_api
branch
from
3479f41
to
c992988
Compare
|
tftr bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a new API v2 endpoint,
POST /api/v2/table_metadata/updatejob.server: create api to trigger table metadata update job
adds a new API v2 endpoint,
POST /api/v2/table_metadata/updatejob.This new API will trigger the table metadata update job
to run and refresh the system.table_metadata table.
This will only trigger the job if it isn't already
running. If the
?onlyIfStalequery param isprovided, the job won't be triggered unless deemed
stale, determined by the following setting:
obs.tablemetadata.data_valid_durationnote that
onlyIfStalewith any value other thenfalsewill be treated as true.Resolves: #128897
Epic: CRDB-37558
Release note: None