Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: create api to trigger table metadata update job #130721

Merged
merged 1 commit into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -2288,6 +2288,7 @@ GO_TARGETS = [
"//pkg/sql/syntheticprivilege:syntheticprivilege",
"//pkg/sql/syntheticprivilege:syntheticprivilege_test",
"//pkg/sql/syntheticprivilegecache:syntheticprivilegecache",
"//pkg/sql/tablemetadatacache/util:util",
"//pkg/sql/tablemetadatacache:tablemetadatacache",
"//pkg/sql/tablemetadatacache:tablemetadatacache_test",
"//pkg/sql/tests:tests",
Expand Down
1 change: 1 addition & 0 deletions pkg/base/testing_knobs.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,5 @@ type TestingKnobs struct {
TenantCapabilitiesTestingKnobs ModuleTestingKnobs
TableStatsKnobs ModuleTestingKnobs
Insights ModuleTestingKnobs
TableMetadata ModuleTestingKnobs
}
4 changes: 4 additions & 0 deletions pkg/server/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,8 @@ go_library(
"//pkg/sql/stats",
"//pkg/sql/stmtdiagnostics",
"//pkg/sql/syntheticprivilegecache",
"//pkg/sql/tablemetadatacache",
"//pkg/sql/tablemetadatacache/util",
"//pkg/sql/ttl/ttljob",
"//pkg/sql/ttl/ttlschedule",
"//pkg/storage",
Expand Down Expand Up @@ -530,6 +532,8 @@ go_test(
"//pkg/sql/sessiondata",
"//pkg/sql/sqlstats",
"//pkg/sql/sqlstats/insights",
"//pkg/sql/tablemetadatacache",
"//pkg/sql/tablemetadatacache/util",
"//pkg/storage",
"//pkg/storage/disk",
"//pkg/storage/fs",
Expand Down
57 changes: 55 additions & 2 deletions pkg/server/api_v2_databases_metadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,16 @@ import (
"github.com/cockroachdb/cockroach/pkg/security/username"
"github.com/cockroachdb/cockroach/pkg/server/apiutil"
"github.com/cockroachdb/cockroach/pkg/server/authserver"
"github.com/cockroachdb/cockroach/pkg/server/serverpb"
"github.com/cockroachdb/cockroach/pkg/server/srverrors"
"github.com/cockroachdb/cockroach/pkg/sql/isql"
"github.com/cockroachdb/cockroach/pkg/sql/sessiondata"
"github.com/cockroachdb/cockroach/pkg/sql/tablemetadatacache"
"github.com/cockroachdb/cockroach/pkg/util/safesql"
"github.com/cockroachdb/cockroach/pkg/util/timeutil"
"github.com/cockroachdb/errors"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
)

const (
Expand All @@ -36,10 +41,19 @@ const (
pageNumKey = "pageNum"
pageSizeKey = "pageSize"
storeIdKey = "storeId"
onlyIfStaleKey = "onlyIfStale"
defaultPageSize = 10
defaultPageNum = 1
)

type JobStatusMessage string

const (
MetadataNotStale JobStatusMessage = "Not enough time has elapsed since last job run"
JobRunning JobStatusMessage = "Job is already running"
JobTriggered JobStatusMessage = "Job triggered successfully"
)

// GetTableMetadata returns a paginated response of table metadata and statistics. This is not a live view of
// the table data but instead is cached data that had been precomputed at an earlier time.
//
Expand Down Expand Up @@ -670,14 +684,13 @@ func (a *apiV2Server) getDBMetadata(
// responses:
//
// "200":
// description: A tmUpdateJobStatusResponse
// description: A tmUpdateJobStatusResponse for GET requests and tmJobTriggeredResponse for POST requests.
// "404":
// description: Not found if the user doesn't have the correct authorizations
func (a *apiV2Server) TableMetadataJob(w http.ResponseWriter, r *http.Request) {
ctx := r.Context()
ctx = a.sqlServer.AnnotateCtx(ctx)
sqlUser := authserver.UserFromHTTPAuthInfoContext(ctx)

authorized, err := a.updateTableMetadataJobAuthorized(ctx, sqlUser)
if err != nil {
srverrors.APIV2InternalError(ctx, err, w)
Expand All @@ -693,6 +706,13 @@ func (a *apiV2Server) TableMetadataJob(w http.ResponseWriter, r *http.Request) {
switch r.Method {
case http.MethodGet:
resp, err = a.getTableMetadataUpdateJobStatus(ctx)
case http.MethodPost:
// onlyIfStale will be true if the query param exists and has any value other than "false"
var onlyIfStale bool
if r.URL.Query().Has(onlyIfStaleKey) {
onlyIfStale = r.URL.Query().Get(onlyIfStaleKey) != "false"
}
resp, err = a.triggerTableMetadataUpdateJob(ctx, onlyIfStale)
default:
http.Error(w, "Method Not Allowed", http.StatusMethodNotAllowed)
return
Expand Down Expand Up @@ -755,6 +775,34 @@ func (a *apiV2Server) getTableMetadataUpdateJobStatus(
return jobStatus, nil
}

// triggerTableMetadataUpdateJob will trigger the table metadata update job if it isn't currently running and if it
// is stale, if onlyIfStale is true.
func (a *apiV2Server) triggerTableMetadataUpdateJob(
ctx context.Context, onlyIfStale bool,
) (tmJobTriggeredResponse, error) {
jobStatus, err := a.getTableMetadataUpdateJobStatus(ctx)
if err != nil {
return tmJobTriggeredResponse{}, err
}

stalenessDuration := tablemetadatacache.DataValidDurationSetting.Get(&a.sqlServer.execCfg.Settings.SV)
if onlyIfStale && jobStatus.LastCompletedTime != nil && timeutil.Since(*jobStatus.LastCompletedTime) < stalenessDuration {
return tmJobTriggeredResponse{JobTriggered: false, Message: MetadataNotStale}, nil
}

_, err = a.status.UpdateTableMetadataCache(ctx, &serverpb.UpdateTableMetadataCacheRequest{Local: false})
if err != nil {
st, ok := status.FromError(err)
if ok {
if st.Code() == codes.Aborted {
return tmJobTriggeredResponse{JobTriggered: false, Message: JobRunning}, nil
}
}
return tmJobTriggeredResponse{}, err
}
return tmJobTriggeredResponse{JobTriggered: true, Message: JobTriggered}, nil
}

func (a *apiV2Server) updateTableMetadataJobAuthorized(
ctx context.Context, sqlUser username.SQLUsername,
) (isAuthorized bool, retErr error) {
Expand Down Expand Up @@ -835,3 +883,8 @@ type tmUpdateJobStatusResponse struct {
LastCompletedTime *time.Time `json:"last_completed_time"`
LastUpdatedTime *time.Time `json:"last_updated_time"`
}

type tmJobTriggeredResponse struct {
JobTriggered bool `json:"job_triggered"`
Message JobStatusMessage `json:"message"`
}
Loading
Loading