sql: plumb LDR originTimestamp from session var to TableWriter #131456
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
msbutler
force-pushed
the
butler-sql-origin-ts
branch
from
c459107
to
e6fff64
Compare
This patch adds a new session variable which only the internal executor may set, that all LDR writes via the SQL layer will set. A future commit will plumb the value of this OriginTimestamp session var and bind it to every batch created by the TableWriter. This patch follows the same plumbing approach we took to plumb the OriginID in cockroachdb#126394 . Epic: none Release note: none
This patch follows the same strategy for plumbing the OriginID from a session variable to every batch request header in the table writer, seen in cockroachdb#126394. In a future commit, Logical Data Replication will use the origin timestamp session variable to ensure all LDR writes are plumbed with their associated OriginTimestamp. Epic: none Release note: none
msbutler
force-pushed
the
butler-sql-origin-ts
branch
from
e0aa592
to
d707369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: bind OriginTimestamp to table writer based on session var
This patch follows the same strategy for plumbing the OriginID from a session
variable to every batch request header in the table writer, seen in #126394.
In a future commit, Logical Data Replication will use the origin timestamp
session variable to ensure all LDR writes are plumbed with their associated
OriginTimestamp.
Epic: none
Release note: none
sessiondata: add OriginTimestampForLogicalDataReplication session var
This patch adds a new session variable which only the internal executor may
set, that all LDR writes via the SQL layer will set. A future commit will plumb
the value of this OriginTimestamp session var and bind it to every batch
created by the TableWriter. This patch follows the same plumbing approach we
took to plumb the OriginID in #126394 .
Epic: none
Release note: none