Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: plumb LDR originTimestamp from session var to TableWriter #131456

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

sql: plumb LDR originTimestamp from session var to TableWriter #131456

wants to merge 2 commits into from

Commits on Sep 27, 2024

  1. sessiondata: add OriginTimestampForLogicalDataReplication session var 

    This patch adds a new session variable which only the internal executor may
set, that all LDR writes via the SQL layer will set. A future commit will plumb
the value of this OriginTimestamp session var and bind it to every batch
created by the TableWriter. This patch follows the same plumbing approach we
took to plumb the OriginID in cockroachdb#126394 .

Epic: none

Release note: none
    @msbutler
    msbutler committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b5c65a0 View commit details
    Browse the repository at this point in the history

  2. sql: bind OriginTimestamp to table writer based on session var 

    This patch follows the same strategy for plumbing the OriginID from a session
variable to every batch request header in the table writer, seen in cockroachdb#126394.

In a future commit, Logical Data Replication will use the origin timestamp
session variable to ensure all LDR writes are plumbed with their associated
OriginTimestamp.

Epic: none

Release note: none
    @msbutler
    msbutler committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d707369 View commit details
    Browse the repository at this point in the history