Fix tests in master branch #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmarqu
approved these changes
Sep 5, 2024
cocotb has deprecated Join with the message "Using task directly is prefered to Join(task) in all situations where the latter could be used.". Awaiting on task is possible in all places where cocotb-bus currently uses Join. Unfortunately the newer approach is not supported on older versions of cocotb. Accordingly two code paths have been introduced in the problematic place. It is a test for cocotb-bus itself, therefore there's no performance impact to check versions there.
There is no constraint on tb.stop() action with regards to all other coroutines waiting for clock rising edge. This may lead to mismatching transactions and expectations being sent to Scoreboard and the following error: AssertionError: Received a transaction but wasn't expecting anything Waiting on ReadOnly trigger ensures that all other coroutines have performed their actions before the testbetch is stopped.
ktbarrett
approved these changes
Sep 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CI tests are broken on master branch due to various reasons. #78 attempted to address at least some of the problems.
The current PR builds on top of #78 and fixes the remaining issues.
cc @cmarqu