Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-compilation #6441

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Fix cross-compilation #6441

merged 6 commits into from
Sep 22, 2023

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Sep 22, 2023

See commit messages for details.

@code-asher code-asher requested a review from a team as a code owner September 22, 2023 00:29
Since the shrinkwrap is what we want everything to use.
@code-asher code-asher changed the title Remove keytar during cross-compile Fix cross-compilation Sep 22, 2023
This was always the original intention.  We should not even have the
yarn.lock in here at all, actually.
Not using CentOS 7 anymore so based on the comment we no longer need
this?
These numbers are all over the place.
@code-asher code-asher merged commit 7868f4d into main Sep 22, 2023
3 of 11 checks passed
@code-asher code-asher deleted the fix-cross-compile branch September 22, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant