feat(vscode-web): support hosting on a subpath with subdomain=false
#288
Conversation
| @@ -160,7 +169,7 @@ resource "coder_app" "vscode-web" { | |||
| display_name = var.display_name | |||
| url = var.folder == "" ? "http://localhost:${var.port}" : "http://localhost:${var.port}?folder=${var.folder}" | |||
| icon = "/icon/code.svg" | |||
| subdomain = true | |||
| subdomain = var.subdomain | |||
There was a problem hiding this comment.
Setting subdomain to false breaks the app. I think you'll have to chang the URL format when it's set.
matifali
changed the title
subdomain=false
|
@matifali I think this has be done for it to work I see the Juypter accomplishing this by setting the url to the full path, but I thought I tried that and it did not work for this. |
I do see that. I think it depends on how urls are constructed within the app. I am pretty sure I tried this with VSCode and it did not. Using the exact same technique. If someone has more time to try it, please do. |
- Consolidates URL and path logic using locals. - Simplifies script syntax, improving maintainability.
|
@code-asher @Emyrk I tested with both We can drop |
| @@ -47,6 +47,7 @@ You can test a module locally by updating the source as follows | |||
| ```tf | |||
| module "example" { | |||
| source = "git::https://github.com/<USERNAME>/<REPO>.git//<MODULE-NAME>?ref=<BRANCH-NAME>" | |||
| # You may need to remove the 'version' field, it is incompatible with some sources. | |||
There was a problem hiding this comment.
Version is into valid when pulling for a terraform module registry confirming to the terraform module protocol.
There was a problem hiding this comment.
So I would just remove this line as no version is required for modules testing from GitHub branches.
Requires coder/coder#14483