-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode-web): support hosting on a subpath with subdomain=false
#288
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
06d2573
chore: add subdomain option to terraform module
Emyrk 27ea0b1
add comment about the version field
Emyrk cadb48f
trying to use base path
Emyrk aacb4c7
change base path
Emyrk bc630be
fix bash template variable
Emyrk 129d692
do not use the same var name for env var
Emyrk cdea2b7
vscode web not code-server, whoops
Emyrk ae6ed88
include coder data blocks
Emyrk 3335b2a
reference from 'me'
Emyrk a52549b
hard code main test
Emyrk 3eecfa9
add '@' to user name
Emyrk b5cad85
try hardcoding something
Emyrk 97dceab
add TODO comment
Emyrk ce5af66
Merge branch 'main' into stevenmasley/subdomain_vscode
matifali b1005ed
Bump `vscode-web` module version to 1.0.22
matifali eb95ea4
Make `SERVER_BASE_PATH` support subdomain option
matifali aa3d9b8
Refactor URL handling in vscode-web module
matifali d606007
Fix whitespace in healthcheck_url variable definition
matifali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting subdomain to false breaks the app. I think you'll have to chang the URL format when it's set.