Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jupyterlab): add support for subdomain=false #316

Merged
merged 20 commits into from
Oct 21, 2024
Merged

feat(jupyterlab): add support for subdomain=false #316

merged 20 commits into from
Oct 21, 2024

Conversation

framctr
Copy link
Contributor

@framctr framctr commented Oct 8, 2024 •
edited by matifali
Loading

Resolves #313

@framctr
Copy link
Contributor Author

framctr commented Oct 8, 2024

I changed also the prints in the run.sh to be compatible with /bin/sh according to https://www.shellcheck.net/wiki/SC2028

matifali
matifali reviewed Oct 8, 2024
View reviewed changes
jupyterlab/main.tf Outdated Show resolved Hide resolved
matifali
matifali reviewed Oct 8, 2024
View reviewed changes
jupyterlab/main.tf Outdated Show resolved Hide resolved
jupyterlab/run.sh Outdated Show resolved Hide resolved
jupyterlab/run.sh Show resolved Hide resolved
matifali
matifali reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. :)

matifali
matifali reviewed Oct 8, 2024
View reviewed changes
jupyterlab/run.sh Outdated Show resolved Hide resolved
@matifali matifali changed the title Add support for subdomain in jupyterlab module fett(jupyterlab): add support for subdomain=fasle Oct 15, 2024
@matifali matifali changed the title fett(jupyterlab): add support for subdomain=fasle feat(jupyterlab): add support for subdomain=fasle Oct 15, 2024
matifali
matifali requested changes Oct 15, 2024
View reviewed changes
jupyterlab/main.tf Outdated Show resolved Hide resolved
matifali
matifali reviewed Oct 15, 2024
View reviewed changes
jupyterlab/main.tf Outdated Show resolved Hide resolved
matifali
matifali reviewed Oct 15, 2024
View reviewed changes
jupyterlab/main.tf Outdated Show resolved Hide resolved
code-asher
code-asher reviewed Oct 15, 2024
View reviewed changes
jupyterlab/main.tf Outdated Show resolved Hide resolved
jupyterlab/main.tf Outdated Show resolved Hide resolved
jupyterlab/run.sh Outdated Show resolved Hide resolved
jupyterlab/main.tf Show resolved Hide resolved
@matifali matifali changed the title feat(jupyterlab): add support for subdomain=fasle feat(jupyterlab): add support for subdomain=false Oct 15, 2024
@matifali matifali mentioned this pull request Oct 15, 2024
Merged
@matifali
Copy link
Member

Hi @framctr, do you plan to finish this? If not, I can help complete this. Thank you :)

@framctr
Copy link
Contributor Author

framctr commented Oct 18, 2024 •
edited
Loading

@matifali
As I said previously, I cannot verify with subdomain=true and for this reason, I didn't update anything more. If you can verify this it would be great. 😊

Anyway, I can do a final check with the last changes with subdomain false.

@matifali
Copy link
Member

I left a few comments and suggestions on possible issues with url.

matifali and others added 3 commits October 21, 2024 08:05
@matifali @code-asher
Update jupyterlab/main.tf
c5c569e 
Co-authored-by: Asher <[email protected]>
@matifali @code-asher
Update jupyterlab/main.tf
0dcba9b 
Co-authored-by: Asher <[email protected]>
@matifali
rename FLAG
3d18984 
Signed-off-by: Muhammad Atif Ali <[email protected]>
@matifali matifali changed the title feat(jupyterlab): add support for subdomain=false feat(jupyterlab): add support for subdomain=false Oct 21, 2024
@matifali matifali merged commit 1b147ae into coder:main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher left review comments

@matifali matifali matifali approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subpath on Jupyterlab module
3 participants
@framctr @matifali @code-asher