feat!(jetbrains-gateway): enable multiple IDE buttons #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for specifying a list of default IDEs to be displayed on the Workspace page. This allows users to see multiple IDE options simultaneously. Ensure no duplicates are included and validate provided IDE codes against allowed set. Adjust logic to dynamically render IDE buttons based on specified defaults, improving flexibility in user interface setup.
- Allow creation of links with multiple IDEs. - Ensure outputs handle arrays for identifying multiple IDEs. - Update runTerraformApply to handle array values as JSON strings.
This change improves URL uniqueness by appending a lowercase IDE identifier to the slug, ensuring distinct slugs for each default IDE.
matifali
commented
Nov 14, 2024
Comment on lines
+203
to
205
| // Convert arrays to JSON strings | ||
| combinedEnv[`TF_VAR_${key}`] = Array.isArray(value) ? JSON.stringify(value) : String(value); | ||
| } |
There was a problem hiding this comment.
This was needed to support list(string) inputs for tests.
|
Works on my end, tested using the following snippet: module "jetbrains_gateway" {
count = data.coder_workspace.me.start_count
source = "git::https://github.com/coder/modules.git//jetbrains-gateway?ref=atif/multi-gateway"
# JetBrains IDEs to make available for the user to select
jetbrains_ides = ["IU", "PY", "WS", "PS", "RD", "CL", "GO", "RM"]
default = ["IU", "PY"]
# Default folder to open when starting a JetBrains IDE
folder = "/home/coder"
agent_id = coder_agent.dev[0].id
agent_name = "dev"
order = 2
}
https://dev.coder.com/templates/coder/aws-linux/versions/strange_goldstine7 |
matifali
changed the title
matifali
changed the title
matifali
changed the title
phorcys420
requested changes
Nov 27, 2024
| @@ -14,12 +14,12 @@ This module adds a JetBrains Gateway Button to open any workspace with a single | |||
| ```tf | |||
| module "jetbrains_gateway" { | |||
| source = "registry.coder.com/modules/jetbrains-gateway/coder" | |||
| version = "1.0.23" | |||
| version = "1.0.24" | |||
There was a problem hiding this comment.
is there any way to make this ver 1.1.0?
This will immediately break templates using the latest version (version = ">= 1.0.0").
We can fix this by doing version = "~> 1.0.0", which will only update 1.0.x versions, but we don't currently follow semver so that sucks.
There was a problem hiding this comment.
Holding it untill we have #157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for specifying a list of default IDEs to be displayed on the Workspace page. This allows users to see multiple IDE options simultaneously.
Closes #338
Caution
This introduces a few breaking changes in the module
defaultis now alist(string)instead ofstring, e.g.list(string)coder_parameterwhen there are multiple items indefault.