feat: add vscode-desktop-core module
#278
Open
+225
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
reviewed
Aug 2, 2025
matifali
reviewed
Aug 3, 2025
Comment on lines
+83
to
+84
| # NOTE: There is a protocol whitelist for the token replacement, so this will only work with the protocols hardcoded in the front-end. | ||
| # (https://github.com/coder/coder/blob/6ba4b5bbc95e2e528d7f5b1e31fffa200ae1a6db/site/src/modules/apps/apps.ts#L18) |
matifali
approved these changes
Aug 3, 2025
There was a problem hiding this comment.
Thanks a lot @phorcys420. This will significantly enhance the DevEX for module development and maintenance.
| > [!CAUTION] | ||
| > We do not recommend using this module directly. Instead, please consider using one of our [Desktop IDE modules](https://registry.coder.com/modules?search=tag%3Aide). | ||
| The VSCode Desktop Core module is a building block for modules that need to expose access to VSCode-based IDEs. It is intended primarily for internal use by Coder to create modules for VSCode-based IDEs. |
There was a problem hiding this comment.
Suggested change
| The VSCode Desktop Core module is a building block for modules that need to expose access to VSCode-based IDEs. It is intended primarily for internal use by Coder to create modules for VSCode-based IDEs. | |
| The VSCode Desktop Core module is a building block for modules that need to expose access to VSCode-based IDEs. It is intended primarily to be used as a library to create modules for VSCode-based IDEs. |
Let's make clear that anyone can use it to support any future VS Code-based IDE modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
vscode-desktop-coremodule that acts similarly as AgentAPI does for other modules as an effort to centralize the logic.This will help with avoiding maintaining multiple modules that do the same thing. I will follow shortly with a PR for a
vscode-web-coremodule to centralize the logic forvscode-webandcode-serveras we've had issues where both would behave differently due to forgetting to update one or the other.This will also help make the amount of effort lower if we ever need to implement a module for another vendor (or if a community member does).
Modules update in #279