-
Notifications
You must be signed in to change notification settings - Fork 42
feat: add vscode-desktop-core
module
#278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
phorcys420
wants to merge
11
commits into
main
Choose a base branch
from
phorcys420/centralize-vscode-desktop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+225
−0
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bbae3d1
feat: add `vscode-desktop-core` module
phorcys420 521a8d2
chore: format
phorcys420 5b6db3d
chore: make `vscode-desktop-core` more readable
phorcys420 ac47d05
fix: use protocol variable
phorcys420 544571b
chore: update readme
phorcys420 14bb16a
chore: fmt
phorcys420 47eca21
Merge branch 'main' into phorcys420/centralize-vscode-desktop
phorcys420 4fd0c76
chore: revert version to 1.0.0
phorcys420 1a62c60
chore: rename `web_app_*` params to `coder_app_*`
phorcys420 03aa37b
chore: add `SESSION_TOKEN` disclaimer
phorcys420 15fe12d
Merge branch 'main' into phorcys420/centralize-vscode-desktop
phorcys420 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
--- | ||
display_name: Coder VSCode Desktop Core | ||
description: Building block for modules that need to link to an external VSCode-based IDE | ||
icon: ../../../../.icons/coder.svg | ||
verified: true | ||
tags: [internal, library] | ||
--- | ||
|
||
# VS Code Desktop Core | ||
|
||
> [!CAUTION] | ||
> We do not recommend using this module directly. Instead, please consider using one of our [Desktop IDE modules](https://registry.coder.com/modules?search=tag%3Aide). | ||
The VSCode Desktop Core module is a building block for modules that need to expose access to VSCode-based IDEs. It is intended primarily for internal use by Coder to create modules for VSCode-based IDEs. | ||
|
||
```tf | ||
module "vscode-desktop-core" { | ||
source = "registry.coder.com/coder/vscode-desktop-core/coder" | ||
version = "1.0.0" | ||
agent_id = var.agent_id | ||
coder_app_icon = "/icon/code.svg" | ||
coder_app_slug = "vscode" | ||
coder_app_display_name = "VS Code Desktop" | ||
coder_app_order = var.order | ||
coder_app_group = var.group | ||
folder = var.folder | ||
open_recent = var.open_recent | ||
protocol = "vscode" | ||
} | ||
``` |
100 changes: 100 additions & 0 deletions
100
registry/coder/modules/vscode-desktop-core/main.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
import { describe, expect, it } from "bun:test"; | ||
import { | ||
runTerraformApply, | ||
runTerraformInit, | ||
testRequiredVariables, | ||
} from "~test"; | ||
|
||
// hardcoded coder_app name in main.tf | ||
const appName = "vscode-desktop"; | ||
|
||
const defaultVariables = { | ||
agent_id: "foo", | ||
coder_app_icon: "/icon/code.svg", | ||
coder_app_slug: "vscode", | ||
coder_app_display_name: "VS Code Desktop", | ||
protocol: "vscode", | ||
} | ||
|
||
describe("vscode-desktop-core", async () => { | ||
await runTerraformInit(import.meta.dir); | ||
|
||
testRequiredVariables(import.meta.dir, defaultVariables); | ||
|
||
it("default output", async () => { | ||
const state = await runTerraformApply(import.meta.dir, defaultVariables); | ||
expect(state.outputs.ide_uri.value).toBe( | ||
`${defaultVariables.protocol}://coder.coder-remote/open?owner=default&workspace=default&url=https://mydeployment.coder.com&token=$SESSION_TOKEN`, | ||
); | ||
|
||
const coder_app = state.resources.find( | ||
(res) => res.type === "coder_app" && res.name === appName, | ||
); | ||
|
||
expect(coder_app).not.toBeNull(); | ||
expect(coder_app?.instances.length).toBe(1); | ||
expect(coder_app?.instances[0].attributes.order).toBeNull(); | ||
}); | ||
|
||
it("adds folder", async () => { | ||
const state = await runTerraformApply(import.meta.dir, { | ||
folder: "/foo/bar", | ||
|
||
...defaultVariables | ||
}); | ||
|
||
expect(state.outputs.ide_uri.value).toBe( | ||
`${defaultVariables.protocol}://coder.coder-remote/open?owner=default&workspace=default&folder=/foo/bar&url=https://mydeployment.coder.com&token=$SESSION_TOKEN`, | ||
); | ||
}); | ||
|
||
it("adds folder and open_recent", async () => { | ||
const state = await runTerraformApply(import.meta.dir, { | ||
folder: "/foo/bar", | ||
open_recent: "true", | ||
|
||
...defaultVariables, | ||
}); | ||
expect(state.outputs.ide_uri.value).toBe( | ||
`${defaultVariables.protocol}://coder.coder-remote/open?owner=default&workspace=default&folder=/foo/bar&openRecent&url=https://mydeployment.coder.com&token=$SESSION_TOKEN`, | ||
); | ||
}); | ||
|
||
it("adds folder but not open_recent", async () => { | ||
const state = await runTerraformApply(import.meta.dir, { | ||
folder: "/foo/bar", | ||
openRecent: "false", | ||
|
||
...defaultVariables, | ||
}); | ||
expect(state.outputs.ide_uri.value).toBe( | ||
`${defaultVariables.protocol}://coder.coder-remote/open?owner=default&workspace=default&folder=/foo/bar&url=https://mydeployment.coder.com&token=$SESSION_TOKEN`, | ||
); | ||
}); | ||
|
||
it("adds open_recent", async () => { | ||
const state = await runTerraformApply(import.meta.dir, { | ||
open_recent: "true", | ||
|
||
...defaultVariables, | ||
}); | ||
expect(state.outputs.ide_uri.value).toBe( | ||
`${defaultVariables.protocol}://coder.coder-remote/open?owner=default&workspace=default&openRecent&url=https://mydeployment.coder.com&token=$SESSION_TOKEN`, | ||
); | ||
}); | ||
|
||
it("expect order to be set", async () => { | ||
const state = await runTerraformApply(import.meta.dir, { | ||
coder_app_order: "22", | ||
...defaultVariables | ||
}); | ||
|
||
const coder_app = state.resources.find( | ||
(res) => res.type === "coder_app" && res.name === appName, | ||
); | ||
|
||
expect(coder_app).not.toBeNull(); | ||
expect(coder_app?.instances.length).toBe(1); | ||
expect(coder_app?.instances[0].attributes.order).toBe(22); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
terraform { | ||
required_version = ">= 1.0" | ||
|
||
required_providers { | ||
coder = { | ||
source = "coder/coder" | ||
version = ">= 2.5" | ||
} | ||
} | ||
} | ||
|
||
variable "agent_id" { | ||
type = string | ||
description = "The ID of a Coder agent." | ||
} | ||
|
||
variable "folder" { | ||
type = string | ||
description = "The folder to open in the IDE." | ||
default = "" | ||
} | ||
|
||
variable "open_recent" { | ||
type = bool | ||
description = "Open the most recent workspace or folder. Falls back to the folder if there is no recent workspace or folder to open." | ||
default = false | ||
} | ||
|
||
variable "protocol" { | ||
matifali marked this conversation as resolved.
Show resolved
Hide resolved
|
||
type = string | ||
description = "The URI protocol the IDE." | ||
} | ||
|
||
variable "coder_app_icon" { | ||
type = string | ||
description = "The icon of the coder_app." | ||
} | ||
|
||
variable "coder_app_slug" { | ||
type = string | ||
description = "The slug of the coder_app." | ||
} | ||
|
||
variable "coder_app_display_name" { | ||
type = string | ||
description = "The display name of the coder_app." | ||
} | ||
|
||
variable "coder_app_order" { | ||
type = number | ||
description = "The order of the coder_app." | ||
default = null | ||
} | ||
|
||
variable "coder_app_group" { | ||
type = string | ||
description = "The group of the coder_app." | ||
default = null | ||
} | ||
|
||
data "coder_workspace" "me" {} | ||
data "coder_workspace_owner" "me" {} | ||
|
||
resource "coder_app" "vscode-desktop" { | ||
agent_id = var.agent_id | ||
external = true | ||
|
||
icon = var.coder_app_icon | ||
slug = var.coder_app_slug | ||
display_name = var.coder_app_display_name | ||
|
||
order = var.coder_app_order | ||
group = var.coder_app_group | ||
|
||
# While the call to "join" is not strictly necessary, it makes the URL more readable. | ||
url = join("", [ | ||
"${var.protocol}://coder.coder-remote/open", | ||
"?owner=${data.coder_workspace_owner.me.name}", | ||
"&workspace=${data.coder_workspace.me.name}", | ||
var.folder != "" ? join("", ["&folder=", var.folder]) : "", | ||
var.open_recent ? "&openRecent" : "", | ||
"&url=${data.coder_workspace.me.access_url}", | ||
# NOTE: There is a protocol whitelist for the token replacement, so this will only work with the protocols hardcoded in the front-end. | ||
# (https://github.com/coder/coder/blob/6ba4b5bbc95e2e528d7f5b1e31fffa200ae1a6db/site/src/modules/apps/apps.ts#L18) | ||
Comment on lines
+83
to
+84
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍🏼 |
||
"&token=$SESSION_TOKEN", | ||
]) | ||
} | ||
|
||
output "ide_uri" { | ||
value = coder_app.vscode-desktop.url | ||
description = "IDE URI." | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make clear that anyone can use it to support any future VS Code-based IDE modules.