-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add coderd_group resource #31
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on Graphite |
0eade27
to
31f7669
Compare
31f7669
to
0d1743d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but you should also wait for Colin's review
stringplanmodifier.RequiresReplace(), | ||
}, | ||
}, | ||
"members": schema.SetAttribute{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For groups (and eventually orgs), we probably should add some settings:
- some property like
unmanaged_members = true
to avoid management of users (aka. only update the org properties not members) - some property like
no_remove_members = true
to avoid removing missing members
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terraform doesn't allow providers to modify configured values. For a user to set unmanaged_members
to true
, they would also need to set members
to null
or an empty list (we'll go with null). We can reasonably implement this, but I don't think we need the field for it, setting members to null can just make members not be managed.
For the same reason, implementing a no_remove_members
would be messy, as it would require us to store some hidden state separate from the configurable members
keeping track of all members that the resource has seen throughout it's lifetime. Is this worth it?
0d1743d
to
773aee7
Compare
773aee7
to
f555328
Compare
Plus some acceptance test clean up.