-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add coderd_organization data source #33
feat: add coderd_organization data source #33
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on Graphite |
29ca20a
to
614c77f
Compare
f95a970
to
695f2f4
Compare
614c77f
to
393c5a9
Compare
695f2f4
to
7dc20eb
Compare
Failing CI is due to the v2.13 tag being deleted and recreated, see Slack. |
}, | ||
"is_default": schema.BoolAttribute{ | ||
MarkdownDescription: "Whether the organization is the default organization of the deployment. This field will be populated if the organization is found by ID or name.", | ||
Optional: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a comment on the UX of this in #34
Optional: true, | ||
Computed: true, | ||
}, | ||
"is_default": schema.BoolAttribute{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is_default is going to become irrelevant very shortly, so we should just stick to ID and name since those will stick around. When orgs get actually released I don't think there will be a "default org" anymore as the concept only exists for placing users into the only existing org.
For now you should just allow id = "default"
(rather than name = "default"
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though it'll be irrelevant shortly, we need to stick with it for the time being. Terraform will always complain if you try to set an attribute to a value that differs from what it was configured to. In this case, we'd need to have a special case to not write the actual ID of the org to the id attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just going to keep the is_default
for now, and we'll end up finalizing it with the rest of the organization implementation.
393c5a9
to
1894bd6
Compare
7dc20eb
to
24a0fe9
Compare
1894bd6
to
355058d
Compare
24a0fe9
to
962336f
Compare
355058d
to
bef1946
Compare
962336f
to
adb48de
Compare
bef1946
to
62ed2be
Compare
e313323
to
63f4357
Compare
63f4357
to
ae0d572
Compare
ae0d572
to
aa86273
Compare
Whilst not really part of the MVP, this makes managing groups through Terraform (such as for our integration tests) a lot nicer, since we can reference the default organisation as a data source.
It does, however, require bumping the coder version to
v2.13
.