feat: partial payouts for cancelled requests #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuHau
force-pushed
the
feat/partial-expired-payouts
branch
from
ead24a4 to
13ae69a
Compare
AuHau
force-pushed
the
feat/partial-expired-payouts
branch
from
13ae69a to
6aed1b6
Compare
|
I have added the verification of the truly canceled state and also the termination of canceled requests in cancelled states (both in purchasing and sales). |
AuHau
force-pushed
the
feat/partial-expired-payouts
branch
from
d0831f4 to
049dd76
Compare
AuHau
force-pushed
the
feat/partial-expired-payouts
branch
from
049dd76 to
4b375ec
Compare
dryajov
pushed a commit
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for partial payouts of canceled requests.
Also closes #556 and fixes off-by-one bug for calling
withdrawFunds()contract function for canceled requests which leads to errors "Request is not expired yet".The integration test is failing, though, because of the Hardhat's mining mode - automine. The time needs to be advanced (eq. mined block) before calling the
withdrawFunds()function for the canceled request, but I have not figured out any way how to do it in the test's code. I have tried switching the Hardhat's mining mode into mining block every second and for that the test worked. Maybe we should consider changing the mining mode? It had brought us more problems recently 😳The PR is blocked by the contract's PR: codex-storage/codex-contracts-eth#69
Also closes codex-storage/codex-contracts-eth#57