-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generalize profile links #1524
Open
cellio
wants to merge
56
commits into
develop
Choose a base branch
from
cellio/1248-generalize-profile-links
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
generalize profile links #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent, edit form is a layout mess and doesn't accept edits yet, attempt at URL validation not yet hooked up
ArtOfCode-
requested changes
Jan 26, 2025
…nance_tasks) and added task to set up user_websites table for existing users
Oaphi
force-pushed
the
cellio/1248-generalize-profile-links
branch
from
January 29, 2025 06:10
648b3ad
to
c85a227
Compare
Oaphi
force-pushed
the
cellio/1248-generalize-profile-links
branch
from
January 29, 2025 06:10
c85a227
to
acaa348
Compare
… rules to whole section
…o longer need to seed labels
…8 lines and kill it...)
ArtOfCode-
requested changes
Feb 1, 2025
This reverts commit ca1d60a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1248.
Adds user-controlled extra fields to the profile to replace the baked-in website and twitter slots. You can put whatever you want here; proper URLs get linkified and everything else is text, like so:
Edit profile section:
Main profile view:
The same link-nerfing rules that applied before apply to this new section.
Added a maintenance task to initialize new table rows for all current users. After discussion, we decided this would be better than constructing new rows on demand (and creating the "add" UI in the editor). When the task is run, all users will get three entries in user_websites, with the first two being filled with the website and twitter links if they exist. This allows the profile editor to present a form with three label/URL pairs for editing. For new users, we add these rows after creation.
Out of scope here (could be considered in the future):
Deployment note: After deploying, visit
/maintenance_tasks
, click on the initialize task (the only one), then click on "run". With a large number of users we might need to do that more than once, so check the output. (I believe the task times out after 5 minutes.)